feat(up): governed one-command stack — secrets, ghcr images, --wait (#7)#16
Merged
Conversation
Turns `agentkit up` from a thin compose wrapper into a one-command governed stack. - src/services.ts: SERVICE_REGISTRY images → ghcr.io/agentkitai/* (were stale agentkit/* placeholders that don't exist). - src/commands/up.ts: ensureSecrets() writes a .env with fresh random LORE_API_KEY/ADMIN_API_KEY/JWT_SECRET on first run (never overwrites; 0600); waitForHealth() polls service health until every REQUIRED service (enabled, has a health endpoint) is running or a timeout elapses — agentlens is non-blocking (known version-skew degraded; reported, not gated). - cli.ts `up`: generates secrets, applies the governance profile by DEFAULT (--profile overrides), and with --wait blocks until healthy (--timeout, default 120s), printing the status table + a ready/timeout verdict and exiting non-zero on timeout so CI can gate. Decision (default, flagged): --wait gates on lore+agentgate health and treats agentlens as known-degraded until the stack version-alignment effort lands — keeps "one command → working stack" honest without blocking on the stale image. Tests: 6 — genSecret (prefix/randomness), ensureSecrets (creates / never overwrites), waitForHealth (becomes ready, agentlens-non-blocking, times out) with an injected clock+status (no real docker/network). Updated the generator image assertion to ghcr. Full suite 57 green. Closes #7. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019tXZpN29akdmG8AEjgSZwk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7. Turns
agentkit upfrom a thin compose wrapper into a one-command governed stack.SERVICE_REGISTRYimages →ghcr.io/agentkitai/*(were staleagentkit/*placeholders).ensureSecrets()writes a.envwith randomLORE_API_KEY/ADMIN_API_KEY/JWT_SECRETon first run — never overwrites, 0600.--wait:waitForHealth()blocks until every required service is healthy or--timeout(default 120s); prints the status table + verdict, exits non-zero on timeout (CI-gateable). agentlens non-blocking (known version-skew — reported, not gated).upapplies the governance profile unless--profileoverrides.Tests: 6 (genSecret, ensureSecrets create/no-overwrite, waitForHealth ready/agentlens-non-blocking/timeout) with an injected clock+status. Full suite 57 green.