fix(mcp): _temporal_request must raise on non-2xx#47
Merged
Conversation
HttpStore._request returns the raw response on 4xx/404 instead of
raising, so the MCP temporal wrapper was formatting error bodies as
``{"status": "ok", "id": null, "superseded_count": null}``. Smoke
test on a freshly merged PR #46 surfaced this — calling
consolidate_memories with bogus source ids reported success despite
the route returning 404 "Source memory not found: nope".
Fix: _temporal_request now inspects status_code and raises
RuntimeError with the server's message / detail / error field on any
non-2xx. The existing ``except Exception as e: return f"Failed to ..."``
clauses on supersede / consolidate_memories / provenance /
supersession_chain / list_at_time turn this into a clear Failed-to
message at the MCP boundary.
Test plan: 4 new tests in test_mcp_provenance_and_recall.py covering
2xx pass-through, 404 with message, 422 with FastAPI's "detail"
field, and the end-to-end consolidate_memories surface that proved
the bug live.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code