Fix filesystem check breaks mesh routing after migration#15
Merged
jpelaez-23blocks merged 1 commit intomainfrom Mar 25, 2026
Merged
Fix filesystem check breaks mesh routing after migration#15jpelaez-23blocks merged 1 commit intomainfrom
jpelaez-23blocks merged 1 commit intomainfrom
Conversation
…em delivery amp-send.sh checked only `[ -d RECIPIENT_AMP_DIR ]` to decide between filesystem vs mesh delivery. After message migration creates directories for remote agents (with only messages/inbox/), all sends incorrectly fell back to local filesystem delivery. Now also checks for config.json which only real local agents have. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jpelaez-23blocks
pushed a commit
that referenced
this pull request
Mar 26, 2026
Adds comprehensive test coverage for the claude-plugin CLI tools using bats-core, catching the 3 shipped production bugs from PRs #14 and #15: - Missing /v1/ prefix in fetch URLs (PR #14) - Millisecond vs seconds timestamps in message IDs (PR #14) - Filesystem delivery without config.json guard (PR #15) Includes: - 140 unit tests covering helpers (address, message ID, routing, signing, storage, sanitize, attachments) and security (injection, trust, wrapping) - 47 integration tests covering send routing, fetch URLs, local send, init flow, register flow, and inbox/read/delete lifecycle - Shared test_helper.bash with env isolation, fixture helpers, curl mocking - GitHub Actions CI workflow running on every PR and push to main - npm-based test runner with bats-core, bats-assert, bats-support Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
amp-send.shlines 478 and 631 checked only[ -d RECIPIENT_AMP_DIR ]to decide local filesystem vs mesh deliverymessages/inbox/), ALL sends incorrectly fell back to local filesystem delivery[ -f config.json ]— only real local agents have this fileReported by:
ai-maestro@rnd23blocks.aimaestro.localvia AMP messageTest plan
🤖 Generated with Claude Code