Merged
Conversation
Contributor
Author
|
I also tweaked the pytest configuration to spit out the run time of the tests which might be interesting for debugging purposes. On my local box, test Confirmed the tests pass and that the docs and readme build locally. |
nickjalbert
commented
Jan 17, 2021
| @@ -1,7 +1,5 @@ | |||
| """The ``agentos`` module provides an API for building learning agents.""" | |||
|
|
|||
| from agentos.version import VERSION as __version__ | |||
Contributor
Author
There was a problem hiding this comment.
flake8 was complaining about this unused import, but is this something we need to make the package work right?
andyk
added a commit
to andyk/agentos
that referenced
this pull request
Jan 21, 2021
Contributor
Author
|
Tests are passing. Merging per our conversation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR runs the black formatter over the repo and fixes any lint complaints (mostly unused imports and variables). My (aesthetic) preference is a max line length of 79 like the standard library, but I'm not dead set on it if you have other preferences.
Lots of file changes, but mostly just tweaking the spacing of statements so this PR didn't take long to put together. If you hate it, we can scrap it and go back to the drawing board and not much will be lost. 😄