golangci: Enable nestif linter, grandfather existing violations#184
Merged
peterj merged 1 commit intoagentregistry-dev:mainfrom Feb 19, 2026
Merged
Conversation
Enable the nestif linter to detect deeply nested if statements. Deeply nested conditionals harm readability by obscuring the main code path and making it harder to maintain line-of-sight through functions. We grandfather existing violations with nolint directives rather than refactoring, since the nested code is often in CLI commands where complexity is inherent. Also flatten a couple test assertions using early returns.
peterj
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the nestif linter to detect deeply nested if statements. Deeply nested conditionals harm readability by obscuring the main code path and making it harder to maintain line-of-sight through functions.
We grandfather existing violations with nolint directives rather than refactoring, since the nested code is often in CLI commands where complexity is inherent. Also flatten a couple test assertions using early returns.