perf(workflow): remove unused agent definition file read in executeAgentTurn#425
Closed
kokevidaurre wants to merge 1 commit intodevelopfrom
Closed
perf(workflow): remove unused agent definition file read in executeAgentTurn#425kokevidaurre wants to merge 1 commit intodevelopfrom
kokevidaurre wants to merge 1 commit intodevelopfrom
Conversation
…entTurn The `definition` variable was loaded via `loadAgentDefinition` on every agent turn but never referenced in the prompt or elsewhere in the function, causing a wasteful disk read per turn. Also removes the now-unused `loadAgentDefinition` import. Fixes #419 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
const definition = loadAgentDefinition(agentPath)call inexecuteAgentTurn— the result was never referenced in the prompt or elsewhere in the functionloadAgentDefinitionimport from./squad-parser.jsloadAgentDefinitionis still correctly used inexecuteGeminiTurn, which embeds the definition directly in the promptImpact
Eliminates one unnecessary disk read per agent turn. Over a full conversation with multiple agents and cycles, this compounds.
Test plan
npm run build)npm testrun directly — 68 test files, 1291 tests)executeAgentTurnbuilds its prompt the same way (referencesagentPathdirectly in the prompt string, telling the agent to read its own definition)Fixes #419
🤖 Generated with Claude Code