fix(workflow): prevent [ERROR] worker turns from silently skipping lead review#426
Closed
kokevidaurre wants to merge 1 commit intodevelopfrom
Closed
fix(workflow): prevent [ERROR] worker turns from silently skipping lead review#426kokevidaurre wants to merge 1 commit intodevelopfrom
kokevidaurre wants to merge 1 commit intodevelopfrom
Conversation
…ad review When workers run in parallel, detectConvergence checked only the last turn after step 3. A successful worker could produce a convergence signal that caused early return, silently discarding [ERROR] output from another worker and skipping the lead review step entirely. Guard: if any worker turn in the current cycle starts with [ERROR], skip the post-worker convergence check so the lead always reviews errors. Fixes #415 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detectConvergenceafter step 3 (workers) checks only the last turn in the transcript. With parallel workers, a successful worker's convergence signal (e.g. "pr created") could cause an early return, silently discarding an[ERROR]result from another worker and skipping the lead review step entirely.detectConvergenceafter workers, check whether any worker turn in the current cycle starts with[ERROR]. If so, skip convergence and always proceed to lead review.Test plan
npm run buildnpm test[ERROR]and another returns a convergence phrase — confirm lead review still runsFixes #415
🤖 Generated with Claude Code