chore: develop → main (54 commits — bot identity, tests, features)#442
Merged
agents-squads[bot] merged 55 commits intomainfrom Mar 7, 2026
Merged
chore: develop → main (54 commits — bot identity, tests, features)#442agents-squads[bot] merged 55 commits intomainfrom
agents-squads[bot] merged 55 commits intomainfrom
Conversation
Closes #342 Co-authored-by: Squads Cloud Worker <cloud@agents-squads.com> Co-authored-by: Claude <noreply@anthropic.com>
…351) Prevents shell injection via crafted paths in background and watch execution modes. Applies same escaping used in foreground mode (PR #324). Adds shellEscape() helper that replaces single quotes with '\'' to safely interpolate variables into single-quoted shell strings. Applied to: - Watch mode: projectRoot, worktreeDir, branchName, logFile, pidFile - Background mode: projectRoot, worktreeDir, branchName, logFile, pidFile - Provider background mode: workDir, logFile, pidFile, provider args - execSync worktree calls in foreground and provider modes Closes #340 Co-authored-by: Squads Cloud Worker <cloud@agents-squads.com> Co-authored-by: Claude <noreply@anthropic.com>
v0.6.2 released, 3 security P1 issue-solvers dispatched, 751 tests passing, Q1 goals 2/3 achieved. Co-authored-by: Squads Cloud Worker <cloud@agents-squads.com> Co-authored-by: Claude <noreply@anthropic.com>
…339) Closes #319 Added default .action(() => cmd.outputHelp()) to 7 parent commands (env, kpi, feedback, session, trigger, approval, autonomous) so they exit 0 instead of 1 when invoked without a subcommand. Matches the pattern already used by memory, goal, deploy, and exec commands. Co-Authored-By: engineering/issue-solver <engineering-issue-solver@agents-squads.com> Agent: engineering/issue-solver Squad: engineering Model: claude-opus-4-6 Co-authored-by: Squads Cloud Worker <cloud@agents-squads.com>
…354) Replace scattered console.log calls with the project's writeLine() utility from src/lib/terminal.ts. This provides a single output layer for consistent formatting and future output control. - Convert 238 console.log calls to writeLine across 10 files - Remove 8 debug/placeholder log statements from anthropic.ts - Keep console.log only for JSON.stringify output (--json flags) and raw prompt piping — standard CLI patterns - Reduction: 269 → 31 occurrences (88% decrease) - Zero new TypeScript errors Files: init.ts, deploy.ts, autonomous.ts, trigger.ts, approval.ts, eval.ts, login.ts, cli.ts, anthropic.ts, update.ts Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
Replace minimal README with comprehensive 331-line version covering: - Quick start with real output examples - Why Squads (4 differentiators) - Provider table (7 LLM providers) - Feature showcase (dashboard, memory, sessions, autonomous, hooks) - Command reference (21 active commands, no removed ones) - Project structure and configuration examples - Development guide and tech stack - Contributing and community links References only current commands (memory write/read instead of learn, env show instead of context, exec list instead of history). 🤖 Generated with [Agents Squads](https://agents-squads.com) Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
Closes agents-squads/engineering#51 Removed the base64-obfuscated API key from source code and replaced with SQUADS_TELEMETRY_KEY env var. Telemetry send is skipped when key is not set. The exposed key must be rotated server-side separately. Co-Authored-By: engineering/issue-solver <engineering-issue-solver@agents-squads.com> Agent: engineering/issue-solver Squad: engineering Model: claude-opus-4-6 Co-authored-by: Squads Cloud Worker <cloud@agents-squads.com>
Closes #343 The daemon process was silently failing because Commander.js rejected the unregistered --daemon CLI flag. Replace with SQUADS_DAEMON env var to signal daemon mode, redirect child stdout/stderr to log file for diagnosability, and show clear error when daemon fails to start. Co-Authored-By: engineering/issue-solver <engineering-issue-solver@agents-squads.com> Agent: engineering/issue-solver Squad: engineering Model: claude-opus-4-6 Co-authored-by: Squads Cloud Worker <cloud@agents-squads.com>
* feat(status): show milestones and open PRs from GitHub squads status now queries GitHub API for real operational data: - Milestone progress bars across product repos (cli, console, api) - Open PRs targeting develop with repo and number Replaces vanity-only output with actionable org health metrics. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(status): discover repos dynamically from squad definitions Replace hardcoded PRODUCT_REPOS array with dynamic discovery: - Read `repo` field from each SQUAD.md frontmatter - Deduplicate and pass to fetchOperationalStatus() - GitHub org derived from squad config, not hardcoded - Dynamic column widths based on actual repo names - Show all open PRs (not just develop-targeted) Any user's squads with `repo:` in SQUAD.md will show milestones + PRs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: rewrite CLAUDE.md as user-facing guide Remove internal references, org names, and dev-specific content. Focus on teaching users how to define squads, run agents, and monitor work. Git-provider agnostic. Engineering standards now live in hq CLAUDE.md (internal only). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Closes #24 Converts ~50 static command imports to dynamic import() inside action handlers. Only the invoked command's dependencies (pg, supabase, inquirer, ora) are loaded, saving ~300ms+ on cold start. Changes: - All command handlers use dynamic import() in their .action() callbacks - autoUpdateOnStartup skipped for --help/--version (instant response) - register*Command imports kept static (needed for subcommand structure) - Type-only import for SessionSummaryData (zero runtime cost) Co-Authored-By: engineering/issue-solver <engineering-issue-solver@agents-squads.com> Agent: engineering/issue-solver Squad: engineering Trigger: manual Model: claude-opus-4-6 Co-authored-by: Squads Cloud Worker <cloud@agents-squads.com>
) Closes #297 Show "squads dash" hints at key touchpoints: - After successful foreground/background agent execution - After lead session completion - After parallel agent launch - In squad detail status commands section Co-Authored-By: engineering/issue-solver <engineering-issue-solver@agents-squads.com> Agent: engineering/issue-solver Squad: engineering Trigger: manual Model: claude-opus-4-6 Co-authored-by: Squads Cloud Worker <cloud@agents-squads.com>
Breaks down the 350-line executeWithClaude into 6 focused functions: - buildAgentEnv: consolidates 3x duplicated env construction - logVerboseExecution: DRYs up verbose config logging (was 2x identical) - createAgentWorktree: isolates Node.js worktree creation - buildDetachedShellScript: shared shell script for watch/background - prepareLogFiles: shared log directory setup - executeForeground: foreground spawn + status tracking - executeWatch: watch mode (background + tail) executeWithClaude is now a ~80-line coordinator that delegates to the appropriate mode function. Closes #158 Co-Authored-By: engineering/issue-solver <engineering-issue-solver@agents-squads.com> Agent: engineering/issue-solver Squad: engineering Model: claude-opus-4-6 Co-authored-by: Squads Cloud Worker <cloud@agents-squads.com>
…dless flags Closes #371 Two fixes for Google/Gemini provider execution: 1. Add --yolo flag to Gemini CLI args for headless auto-approval. Without this, Gemini denies all tool calls when running in background because it can't prompt for interactive confirmation. 2. Copy .agents directory into worktree and rewrite prompt paths. Gemini CLI sandboxes file access to its workspace directory. The prompt references agent definitions at the original project root, which Gemini blocks as "Path not in workspace". Now we copy .agents into the worktree and rewrite absolute paths so Gemini can resolve them. Co-Authored-By: engineering/issue-solver <engineering-issue-solver@agents-squads.com> Agent: engineering/issue-solver Squad: engineering Model: claude-opus-4-6 Co-authored-by: Squads Cloud Worker <cloud@agents-squads.com>
Closes #280 Implements `squads create <name>` that creates: - .agents/squads/<name>/SQUAD.md (from template) - .agents/squads/<name>/lead.md (starter agent) - .agents/memory/<name>/lead/ (memory directory) Supports --description, --goal, --model flags for non-interactive use, and interactive prompts via inquirer when flags are omitted. Includes --force for overwriting and --yes for CI/scripting. Note: organization.yaml is not used — squads are discovered dynamically via filesystem (squad-parser.ts findSquadsDir + listSquads). 11 tests covering directory creation, content, naming, overwrite protection, and squad discoverability. Co-Authored-By: engineering/issue-solver <engineering-issue-solver@agents-squads.com> Agent: engineering/issue-solver Squad: engineering Trigger: manual Model: claude-opus-4-6 Co-authored-by: Squads Cloud Worker <cloud@agents-squads.com>
Closes #366 When --cloud is set, the CLI dispatches agent execution to the platform API instead of running locally. Requires `squads login` session and SQUADS_API_URL environment variable. Flow: - POST /agent-dispatch to create dispatch request - Poll /agent-executions for status updates - Display execution summary on completion Co-Authored-By: engineering/issue-solver <engineering-issue-solver@agents-squads.com> Agent: engineering/issue-solver Squad: engineering Trigger: smart Model: claude-opus-4-6 Co-authored-by: Squads Cloud Worker <cloud@agents-squads.com>
Closes #316 Added 63 tests covering 2 of the 6 lib modules listed in the issue: - setup-checks.ts (48 tests): providers registry, commandExists, isDockerRunning, checkDockerPrereqs, checkGhCli, checkGhPermissions, checkClaudeCli, checkProviderAuth, runPrereqChecks, runAuthChecks, displayCheckResults, attemptFix, waitForService - local.ts (15 tests): getLocalEnvVars, formatLocalStatus, isLangfuseLocal, getLocalStackStatus Co-authored-by: Squads Cloud Worker <cloud@agents-squads.com> Co-authored-by: Claude <noreply@anthropic.com>
…urces (#382) Closes #314. Adds 115 tests across 4 test files achieving 92% statement coverage and 80% branch coverage on the dashboard module: - dashboard-loader.test.ts: 16 tests for findDashboardsDir, listDashboards, loadDashboard, clearDashboardCache, loadAllDashboards, findDashboard - dashboard-renderers.test.ts: 49 tests for formatValue (all formats), getThresholdColor, calculateColumnWidths, and renderView (all view types) - dashboard-sources.test.ts: 31 tests for buildQuery, buildWhereClause, parseDateRange, and postgresSource stub - dashboard-engine.test.ts: 19 tests for executeDashboard, renderDashboard, and showAvailableDashboards with mocked dependencies Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
…381) Closes #51 Changes: - db.test.ts: Enable 4 previously skipped baseline tests (saveBaseline, getLatestBaseline, getBaselineByName, listBaselines) — stubs are implemented, tests were incorrectly marked as not-yet-implemented - sessions.test.ts: Add 30 new tests covering file-system operations: findAgentsDir, getSessionsDir, getHistoryFilePath, getActiveSessions, getSessionSummary, startSession, stopSession, updateHeartbeat, cleanupStaleSessions — all use temp dirs to avoid test pollution Also expanded detectSquad, detectAIProcessesFast, getLiveSessionSummaryFast Total: 63 → 104 tests passing, 0 skipped Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
Post-execution instructions (branch, commit, PR workflow) now loaded from .agents/config/post-execution.md instead of inline template string in run.ts. Separates prompt content from code. Same pattern as approval-instructions.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit 9999f92700c02af522e15cae29097a60f249cf15.
…eck (#389) * fix(ci): run CI on PRs to develop — quality gate for agent PRs Agents create PRs targeting develop. Without CI on develop PRs, broken code gets merged undetected. This is the #1 quality gap. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(quality): pre-commit hook runs build + tests on source changes Agents were committing broken code (e.g. #384: tests that fail on import). Now any commit touching .ts/.tsx/.js files must pass both `npm run build` and `npm run test` before the commit goes through. This is the #1 quality gate — prevents slop at the source. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(tests): align failing tests with implementation - deploy.test: capture process.stdout.write instead of console.log (deployCommand uses writeLine which writes to stdout) - eval.test: same stdout capture fix for JSON output test - infra.test: use POSTGRES_PORT env var (default 5433) to match docker-compose pattern - local.test: expect port 5432 in DATABASE_URL matching getLocalEnvVars() - setup-checks.test: expect 'warning' (not 'missing') when Docker is not installed, matching checkDockerPrereqs() implementation - Deleted verify-token.test.ts (tested nonexistent verifyToken export) Co-Authored-By: Claude <noreply@anthropic.com> * fix(agents): proper PR workflow — target develop, daemon env, auth check - Post-execution: agents now open PRs targeting `develop` with structured body - Daemon (autonomous.ts): unset CLAUDECODE env to allow nested claude sessions - Auth check: downgrade missing credentials from block to warn (keychain auth) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * refactor(run): extract post-execution prompt to template file Post-execution instructions (branch, commit, PR workflow) now loaded from .agents/config/post-execution.md instead of inline template string. Separates prompt content from code. Same pattern as approval-instructions.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
- Add missing env-config.ts (imported by run.ts but never committed) - Fix Commander action spread types with @ts-expect-error directives - Add inquirer type declaration for create command Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…tines' (#392) Regex only matched '## Routines' exactly, missing Engineering squad's '## Growth Routines' header. Now matches any word before 'Routines'. Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Multi-agent conversation orchestration for squad runs:
- Lead briefs → scanners discover → workers execute → lead reviews → verifiers check
- Shared transcript between agents for context continuity
- Convergence detection (continuation signals beat convergence signals)
- Cost ceiling ($25 default) and max turns (20 default) safety limits
- --task flag for founder directives (replaces lead briefing)
- Transcript persistence to .agents/conversations/{squad}/
New files:
- src/lib/conversation.ts — types, transcript, agent classification, convergence
- src/lib/workflow.ts — turn execution, orchestration loop, transcript persistence
`squads run <squad>` now runs a full conversation instead of just the lead agent.
`squads run <squad> -a <agent>` still runs individual agents (unchanged).
Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
* fix(auth): add verifyToken function and passing test suite Closes #384 Adds verifyToken(token, apiUrl) to src/lib/auth.ts: - Calls GET /auth/verify with Bearer token header - Maps snake_case API response to camelCase (display_name→name, subscription_plan→plan) - Returns null on non-ok responses, network errors, and timeouts/aborts - 5-second abort timeout to prevent hanging Creates test/verify-token.test.ts with all 6 specified tests: 1. Returns user data on 200 with snake_case→camelCase mapping 2. Returns null on non-ok response (e.g. 401) 3. Returns null on network error (silent) 4. Returns null on timeout/abort 5. Sends Bearer token in Authorization header 6. Builds correct URL from apiUrl param Co-Authored-By: cli/issue-solver <cli-issue-solver@agents-squads.com> Agent: cli/issue-solver Squad: cli * fix(auth): update verifyToken signature and response to match API spec Revises the initial implementation based on actual API contract: - Parameter order: verifyToken(apiUrl, token) — apiUrl first - Endpoint: /auth/cli/verify (not /auth/verify) - Response shape: { email, tenantId, tenantSlug, tenantName, status } mapping from snake_case { tenant_id, tenant_slug, tenant_name } - Updates test/verify-token.test.ts to use vi.stubGlobal per-test with afterEach cleanup for better test isolation All 6 tests pass. Co-Authored-By: cli/issue-solver <cli-issue-solver@agents-squads.com> Agent: cli/issue-solver Squad: cli --------- Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com>
* test(commands): add unit tests for goal and list commands Adds 21 new tests covering: - goal.test.ts (14 tests): goalSetCommand, goalListCommand, goalCompleteCommand, goalProgressCommand — including edge cases for invalid indexes, non-existent squads, metric annotations - list.test.ts (7 tests): JSON output validation, agent counts, no-project error handling, table and agents view rendering Partial fix for #47 — covers 2 of 19 untested command files. Co-Authored-By: engineering/issue-solver <engineering-issue-solver@agents-squads.com> Agent: engineering/issue-solver Squad: engineering Model: claude-opus-4-6 * test: add unit tests for feedback and progress commands Closes #47 (partial — 2 of 15 untested commands) Added 19 tests covering: - feedback: add, show, parse history, rating validation, learnings - progress: start/complete tasks, display, verbose mode, task IDs Co-Authored-By: engineering/issue-solver <engineering-issue-solver@agents-squads.com> Agent: engineering/issue-solver Squad: engineering Model: claude-opus-4-6 --------- Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com>
…ification - classifyAgent now uses role descriptions from SQUAD.md (primary) with name-based fallback — no more regex substring collisions - Strip **bold** markers from agent names in table parser - Replace regex convergence/continuation signals with phrase matching - "keychain auth" → "OAuth" in run output Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- session.test.ts: 11 tests covering sessionStartCommand, sessionStopCommand, sessionHeartbeatCommand, and detectSquadCommand (start/stop/heartbeat lifecycle, quiet mode, missing .agents dir) - learn.test.ts: 14 tests covering learnCommand, learnShowCommand, and learnSearchCommand (default squad, specific squad, fallback, category inference, tag extraction, search, filters) Part of #47 — adds coverage for 2 more previously untested commands. Co-Authored-By: cli/issue-solver <cli-issue-solver@agents-squads.com> Agent: cli/issue-solver Squad: cli Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com>
Closes #400 Updated keywords to align with README comparison table: - Added: crewai-alternative, autogen-alternative, langgraph-alternative - Added: autonomous-agents, agent-framework, ai-automation, workforce - Removed: ai-team (vague) - Total: 20 keywords, all lowercase, hyphen-separated Co-Authored-By: growth/growth-worker <growth-growth-worker@agents-squads.com> Agent: growth/growth-worker Squad: growth Model: claude-sonnet-4-5 Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com>
Checks installed tools (core/recommended/optional), authentication status (Anthropic, GitHub, GCloud), and project structure. Shows new users what they can do now and what to install next. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Docker, Postgres, Redis, DuckDB, psql, gcloud, gws are infrastructure for cloud execution, not local squads. Doctor should only show tools agents actually use: claude, git, node, gh, python3, jq, curl. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Shows running squads (with task and elapsed time), daemon status, and recent conversation transcripts with turn count and cost. One command to see everything: squads doctor Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Box layout with sections: Tools, Auth, Project, Live Execution. Shows running squads with task preview, recent conversations with turn counts and costs. Matches squads brand colors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Revert from box layout to concise flat format. Auth now shows actual accounts: claude whoami for Claude, gcloud config for GCP. One-line auth row, compact project info, clean live monitoring. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Scanners, workers, and verifiers now run simultaneously when a squad has multiple agents in the same role. Sequential order preserved between roles (lead → scanners → workers → lead review → verifiers). Marketing squad example: content-worker + social-poster run in parallel, cutting cycle wall-clock time from ~5 turns to ~3 turns. Single-agent roles still use execSync (no overhead). Multi-agent roles use async exec with Promise.all. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CI all green. Unit tests for sessions and status commands. Part of cli#47 test coverage effort.
Closes #47 (partial) - health.test.ts: 9 tests for healthCommand covering all services down, all healthy, degraded, verbose mode, trigger stats - kpi.test.ts: 26 tests across kpiShowCommand, kpiRecordCommand, kpiTrendCommand, kpiInsightsCommand, kpiListCommand covering squad not found, no KPIs, recording, validation, JSON output Commands now tested: 20/34 in develop Co-Authored-By: cli/issue-solver <cli-issue-solver@agents-squads.com> Agent: cli/issue-solver Squad: cli Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com>
Closes #281 Adds --repo and --org flags to `squads create` that: - Create a private GitHub repo via gh CLI - Auto-detect org from git remote if --org not specified - Handle errors gracefully (local squad created even if GitHub fails) - Show repo URL in success output New files: - src/lib/github.ts: createGitHubRepo(), detectGitHubOrg() Tests: 4 new tests in test/commands/create.test.ts (15 total, all passing) Co-Authored-By: cli/issue-solver <cli-issue-solver@agents-squads.com> Agent: cli/issue-solver Squad: cli Model: claude-sonnet-4-6 Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com>
- Add cwd field to AgentTurnConfig interface - Fix executeAgentTurn (sync) to use config.cwd || process.cwd() - Fix executeAgentTurnAsync to use config.cwd || process.cwd() - Add squad cwd resolution in runConversation: squadsDir/../../../<repo> (was incorrectly using squadsDir/../.. which resolved to project root, not the parent directory containing sibling repos) - Pass squadCwd to all 8 executeAgentTurn/Async call sites Co-authored-by: kokevidaurre <kokevidaurre@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
- #419: remove unused loadAgentDefinition call in executeAgentTurn (perf) - #417: detectConvergence now checks verifier role first — approval phrases converge, rejection phrases continue cycle - #415: worker [ERROR] outputs now emit stderr [WARN] before lead review Closes #415, #417, #419 Co-authored-by: Test <test@test.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Part of #47 12 tests covering: - Command registration - Squad not found → exit(1) - No lead agent → exit(1) - Background mode spawns tmux with correct args - Foreground mode spawns claude with stdio:inherit - Squad env vars passed to spawned process - initEventsDir/buildLeadPrompt called correctly - MCP config path resolved when squad has mcp servers Agent: cli/issue-solver Squad: cli Co-authored-by: cli/issue-solver <cli-issue-solver@agents-squads.com>
…ranscript (#428) Add transcript compaction to serializeTranscript. The original draft contained a dead dedup check: compacted[0] === compacted[1] used object reference equality. Since lastReviewIdx is always > 0 (loop starts at i > 0), these objects can never be reference-equal — the check is always false and the dedup never fires. Fix: remove the dead check and assign the compacted array directly. Fixes #418 Co-authored-by: Test <test@test.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
- approval.test.ts: 16 tests covering list, check (exit codes), send, cancel subcommands; process.exit mocked to throw for clean assertions - context.test.ts: 22 tests covering contextShowCommand, contextListCommand, contextActivateCommand, contextPromptCommand; includes json output, dry-run mode, no-squads-dir edge cases Part of #47 (unit tests for commands/ directory). Commands tested: 23/35 Co-Authored-By: cli/issue-solver <cli-issue-solver@agents-squads.com> Agent: cli/issue-solver Squad: cli Co-authored-by: Test <test@test.com>
Closes #282 - Add createSquadChannel() to src/lib/slack.ts - Calls conversations.create API, returns channel ID string - Sets topic via conversations.setTopic (non-fatal if fails) - Handles name_taken gracefully by returning existing channel ID - Add --slack / -s flag to src/commands/create.ts - Creates squad-<name> channel after local files created - Shows channel name in success output - Continues gracefully if Slack returns null - Register -s, --slack option and example in src/cli.ts - Add 4 tests to test/commands/create.test.ts fix(test): clear GIT env vars in beforeAll to prevent pre-commit pollution When tests run inside a git pre-commit hook, GIT_DIR is set to the worktree git directory. Without clearing it, git commands executed in temp directories (git init, git commit) operate on the hook repository branch instead of the intended temp directory, corrupting the branch. Fix applied to test/git.test.ts, test/e2e/workflows.e2e.test.ts, and test/e2e/cli-commands.e2e.test.ts. Co-Authored-By: cli/issue-solver <cli-issue-solver@agents-squads.com> Agent: cli/issue-solver Squad: cli Co-authored-by: Test <test@test.com>
Closes #161 (partial - first extraction step) Moves PlanType, PlanDetection, detectPlan, getPlanType, isMaxPlan, getPlanDescription out of costs.ts (1202 lines) into a focused src/lib/plan.ts module. costs.ts re-exports for backwards compat. Reduces costs.ts from 1202 to 1118 lines (-84 lines). All existing imports from costs.ts continue to work unchanged. Also fixes git.test.ts GIT_DIR hook recursion bug by clearing GIT_DIR and GIT_WORK_TREE in beforeEach. Co-Authored-By: cli/issue-solver <cli-issue-solver@agents-squads.com> Agent: cli/issue-solver Squad: cli Co-authored-by: Jorge Vidaurre <jorge@agents-squads.com>
* feat(github): bot-authored commits, dynamic AI co-authors, daemon command - GitHub App auth: JWT → installation token for bot identity - Commits authored by agents-squads[bot], pushed via bot token - Dynamic Co-Authored-By trailers: claude[bot], gemini-code-assist, etc. - Daemon command: persistent intelligence loop (watch, decide, dispatch) - API client: fire-and-forget conversation result reporting Co-Authored-By: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * feat(daemon): react to review feedback from Gemini and other reviewers Daemon now checks for review comments on bot-authored PRs each cycle. When Gemini Code Assist or humans leave feedback, it dispatches an agent to read the comments, fix the code, and push updates to the PR branch. Co-Authored-By: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * ci: add changesets, codecov, auto-labeler, drop Node 18 - Changesets: auto-versioning on merge, GitHub-linked changelog - Codecov: coverage reporting via vitest --coverage - Auto-labeler: labels PRs by file path (core, commands, ci, docs, tests) - Drop Node 18 (EOL), keep 20 + 22 - Artifacts uploaded from Node 22 (latest LTS) Co-Authored-By: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * fix(security): address Gemini code review — injection, hardcoded config, DRY Fixes all issues from gemini-code-assist review: - CRITICAL: Use git commit --file instead of inline message (shell injection) - CRITICAL: Use spawnSync args array for git push (URL injection) - HIGH: Dynamic SQUAD_REPOS from SQUAD.md repo: field instead of hardcoded map - HIGH: Replace execSync curl with native fetch for Slack notifications - MEDIUM: Extract defaultState() to avoid DRY violation Co-Authored-By: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * fix: use detectedProvider in executeForeground call (TS18004) Co-Authored-By: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * fix(ci): split changeset check (PR) from release (main push) PR workflow just checks for changeset existence — no push needed. Release workflow on main push creates the version PR with changesets/action. Co-Authored-By: claude[bot] <209825114+claude[bot]@users.noreply.github.com> --------- Co-authored-by: agents-squads[bot] <266303152+agents-squads[bot]@users.noreply.github.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a significant accumulation of features, bug fixes, and infrastructure enhancements from the Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Keep develop's new features (bot identity, daemon, API reporting, co-author trailers) plus main's --slack option for create command. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This is a substantial pull request merging 54 commits from develop into main, introducing a wide range of improvements and new features. The key changes, including the implementation of a GitHub App bot identity, a new daemon command, dynamic AI co-authors, and a squad conversation protocol, are impressive and well-executed. The lazy-loading of commands in src/cli.ts is an excellent performance optimization for a CLI tool. The security enhancements, such as removing the hardcoded telemetry key and preventing shell injection in src/commands/run.ts, are critical and well-implemented. The addition of numerous tests significantly improves the project's robustness. I have one minor suggestion regarding the new pre-commit hook to ensure its pattern matching is as precise as possible. Overall, this is a fantastic set of updates that greatly enhances the capabilities and quality of the project.
Note: Security Review did not run due to the size of the PR.
I am having trouble creating individual review comments. Click here to see my feedback.
.husky/pre-commit (9-32)
Some patterns in this list contain unescaped dots (.). In an extended regular expression (used with grep -E), a dot matches any single character, which could lead to incorrect matches (e.g., parqueXarauco would be blocked). To match a literal dot, it should be escaped with a backslash (\.). This is already done for patterns like directives\.md and should be applied consistently to avoid potential false positives and ensure the blocklist is precise.
The affected patterns are:
parque.araucoaguas.andinasAndes.Movesburn.rateconsulting.revenue
"innspiral"
"sg2030"
"parque\.arauco"
"sodimac"
"enaex"
"hortifrut"
"aguas\.andinas"
"cmpc"
"Andes\.Moves"
"Andes.Movements"
# Internal references
"squads-hq"
"daily-briefing"
"directives\.md"
"goals\.md"
"state\.md"
# Personal emails (add more as needed)
"kokevidaurre@"
"jorgevidaurre@"
# Strategy/financial
"burn\.rate"
"runway"
"consulting\.revenue"
"pricing-strategy"
![agents-squads[bot]](https://avatars.githubusercontent.com/in/3032119?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accumulation of 54 commits on develop since last main merge (PR #395):
Key changes:
Previous PR
PR #440 was closed due to merge conflicts after #395 squash-merge to main.
Review needed
Founder review required for develop → main merge.
Agent: company/company-lead (Run 12)