fix: org cycle agent name bug + quota detection#638
Conversation
Bug 1: runAgent was called with (path, name) instead of (name, path).
Caused agent names to show as full file paths in observability.
Bug 2: when Claude hits quota limit ("hit your limit", exit code 1),
org cycle now detects it (two consecutive fast failures <10s) and
stops instead of trying all remaining squads.
Co-Authored-By: Claude <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces quota and rate limit detection within the runCommand function, allowing the execution cycle to stop early if limits are reached. The feedback suggests consolidating the calculation of failure duration to ensure consistency across the logic and recommends extracting the magic number used for the failure threshold into a named constant for better maintainability.
| results.push({ squad: s.squad, agent: s.lead, status: 'failed', durationMs: Date.now() - runStart }); | ||
| writeLine(` ${colors.red}${s.squad}/${s.lead} failed: ${e instanceof Error ? e.message : String(e)}${RESET}`); | ||
|
|
||
| // Detect quota limit — if agent fails in <10s, likely quota/rate limit | ||
| const failDuration = Date.now() - runStart; |
There was a problem hiding this comment.
To ensure consistency and avoid multiple Date.now() calls which could yield slightly different results, it's better to calculate the duration once and reuse it for both the results array and the subsequent quota check.
| results.push({ squad: s.squad, agent: s.lead, status: 'failed', durationMs: Date.now() - runStart }); | |
| writeLine(` ${colors.red}${s.squad}/${s.lead} failed: ${e instanceof Error ? e.message : String(e)}${RESET}`); | |
| // Detect quota limit — if agent fails in <10s, likely quota/rate limit | |
| const failDuration = Date.now() - runStart; | |
| const failDuration = Date.now() - runStart; | |
| results.push({ squad: s.squad, agent: s.lead, status: 'failed', durationMs: failDuration }); | |
| // Detect quota limit — if agent fails in <10s, likely quota/rate limit |
|
|
||
| // Detect quota limit — if agent fails in <10s, likely quota/rate limit | ||
| const failDuration = Date.now() - runStart; | ||
| const isQuotaLikely = failDuration < 10000 && errMsg.includes('code 1'); |
There was a problem hiding this comment.
The magic number 10000 is used here and on line 109 to define a 'fast failure'. It would be better to extract this into a named constant at the top of the catch block for clarity and easier maintenance. For example: const FAST_FAILURE_THRESHOLD_MS = 10000;
1 participant
Fixes swapped args (name showed as full path) and adds quota detection (stops cycle after 2 consecutive fast failures).