fix(services): make agnostic — remove hardcoded paths [v0.3.0]#738
Merged
kokevidaurre merged 2 commits intodevelopfrom Apr 14, 2026
Merged
fix(services): make agnostic — remove hardcoded paths [v0.3.0]#738kokevidaurre merged 2 commits intodevelopfrom
kokevidaurre merged 2 commits intodevelopfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the squads services command to enhance Docker Compose file discovery, supporting environment variables and project-root-based searching, while adding a --file option for manual overrides. The feedback highlights several areas for improvement: correcting the health check logic to ensure services are actually running rather than just not transitioning, validating the existence of user-provided file paths, ensuring consistent support for .yaml extensions in the infra directory, and maintaining feature parity for the --file option across all subcommands.
Contributor
Author
|
Closing — services command is Tier 2 tooling, not needed for v0.3.0. Will redesign if needed for v0.4.0. |
…sumptions Before: searched for docker-compose.yml in ~/agents-squads/engineering/docker/ and hardcoded squads-postgres container name, internal DB table names. Now: - Discovers docker-compose.yml from project root, ./docker/, ./infra/, SQUADS_COMPOSE_FILE env var, or --file flag - Uses docker compose ps against user's compose file - Removed hardcoded port output and DB introspection - --file option on all 3 subcommands (up/down/status) - Health check verifies containers are actually running - Updated tests to match new agnostic implementation Co-Authored-By: Claude <noreply@anthropic.com>
kokevidaurre
force-pushed
the
fix/services-agnostic
branch
from
dc356c5 to
ec72900
Compare
- Use SQUADS_COMPOSE_FILE env var instead of hardcoded engineering path - Check --file option on all subcommands - Fix health check mock to return 'running' state - Updated status test for Docker not installed case Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Services command had hardcoded paths to our engineering repo and internal DB table names. Now fully agnostic.
Changes
SQUADS_COMPOSE_FILEenv var--fileflag for explicit pathdocker compose psagainst user's compose fileTest plan
npm run buildpassessquads services statuswith Docker runningsquads services statuswithout DockerCloses hardcoded paths issue found during v0.3.0 review.