fix(telemetry): restore write-only API key — broken since March 14 [v0.3.0]#739
Merged
kokevidaurre merged 3 commits intodevelopfrom Apr 14, 2026
Merged
fix(telemetry): restore write-only API key — broken since March 14 [v0.3.0]#739kokevidaurre merged 3 commits intodevelopfrom
kokevidaurre merged 3 commits intodevelopfrom
Conversation
…arch 14 Commit 6261882 removed the telemetry key and replaced it with an env var that no user has set. Result: zero telemetry events since ~March 14. Write-only analytics keys are standard practice (Segment, PostHog, Mixpanel all ship them in public code). The key can only write events; it cannot read, delete, or access any data. Users can still opt out. Closes #388 (GitHub Traffic API — this restores our primary data signal) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a hardcoded, base64-encoded telemetry key as a fallback for CLI analytics. Feedback indicates that hardcoding this key violates engineering guidelines and poses a security risk, suggesting that the key should be injected during the build process or kept as a plain string for transparency if embedding is necessary.
Gemini review: base64 encoding adds no security and reduces transparency. Plain string is honest — it's a write-only key, nothing to hide. Co-Authored-By: Claude <noreply@anthropic.com>
Telemetry goes to our infrastructure only. No reason to let users redirect it. They can opt out, but not redirect. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Telemetry has been dead since March 14. Zero events in 30 days. Root cause: commit 6261882 replaced the write-only key with an env var no user has set.
Fix
Restore the embedded write-only key. Standard practice for CLI analytics — Segment, PostHog, Mixpanel all ship write-only keys in public code. The key can only write events; it cannot read or access any data. Users can opt out.
Impact
Test plan
Co-Authored-By: Claude noreply@anthropic.com