Skip to content

Conversation

@guanxuc
Copy link
Contributor

@guanxuc guanxuc commented Jan 24, 2026

AgentScope-Java Version

1.0.8

Description

doc(rag): Add tika reader docs

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@guanxuc guanxuc requested a review from a team January 24, 2026 16:23
@gemini-code-assist
Copy link

Summary of Changes

Hello @guanxuc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the modularity of the rag-simple extension by converting its external library dependencies into optional components. This change allows users to selectively include only the required libraries for their specific Retrieval Augmented Generation (RAG) use cases, thereby reducing the overall dependency footprint and improving flexibility.

Highlights

  • Dependency Optionality: The rag-simple module's external dependencies, including agentscope-core, openai-java, qdrant-client, and various document processing libraries, have been marked as optional in pom.xml to reduce the default dependency footprint.
  • Javadoc Enhancement: Javadoc comments have been added to the TikaReader class, providing a clear description of its functionality, supported formats, and an example usage.
  • Documentation Update: The installation guides (both English and Chinese versions) have been updated to include Apache Tika Core and Parsers as optional dependencies for document processing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the agentscope-extensions-rag-simple module to make its dependencies optional. This is a good architectural improvement that prevents bloating projects with unused transitive dependencies. The changes in pom.xml correctly use <optional>true</optional> and <scope>provided</scope> for this purpose. The documentation has been updated to reflect these changes, and a helpful Javadoc has been added to TikaReader. I've suggested a minor formatting improvement in the markdown documentation files to enhance readability.

@guanxuc guanxuc force-pushed the optional-rag branch 2 times, most recently from 24c31c8 to d992ae8 Compare January 25, 2026 14:25
@guanxuc guanxuc changed the title chore(rag): Make rag-simple dependency optional doc(rag): Add tika reader docs Jan 25, 2026
@codecov
Copy link

codecov bot commented Jan 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@AlbumenJ AlbumenJ merged commit 8d37f8e into agentscope-ai:main Jan 26, 2026
5 checks passed
@guanxuc guanxuc deleted the optional-rag branch January 26, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants