ci(observer-deploy): disable NetworkPolicy in smoke stack#60
Merged
Conversation
PR #58 introduced templates/networkpolicy.yaml gated on cluster.enabled. The smoke job sets cluster.enabled=True (per PR #58 spec, to validate multi-pod behaviour end-to-end), so the NetworkPolicy manifest renders. But dev-yuzishu's observer-github-actions ServiceAccount lacks the networkpolicies.networking.k8s.io RBAC, so `helm install` fails on the resource discovery lookup. Fix: pass cluster.networkPolicy.enabled=false in the smoke values. NP is defense-in-depth (per spec §Internal NetworkPolicy), not the primary auth (HMAC+nonce is). The smoke stack still exercises the shared registry, forwarding, drain, and cluster secret rotation paths. Release job (production) keeps NetworkPolicy on by default via values-production.example.yaml. Fixes broken 'observer build and deploy / smoke' job on master post PR #58 merge. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-#58 hotfix: smoke job fails because the dev-yuzishu SA lacks networkpolicies RBAC. Disables NP for smoke only; release/production keeps it on.
Failure:
🤖 Generated with Claude Code