fix(chart): add resources block to assert-cluster-secret init container#63
Merged
Merged
Conversation
PR #58's Phase E3 added the assert-cluster-secret init container without resource requests/limits. dev-yuzishu (and any namespace with a ResourceQuota that requires per-container cpu/memory) rejects the Deployment: Error creating: pods "observer-ci-50-observer-..." is forbidden: failed quota: resource-quota: must specify limits.cpu for: assert-cluster-secret; limits.memory for: assert-cluster-secret; requests.cpu for: assert-cluster-secret; requests.memory for: assert-cluster-secret Fix: add cluster.assertSecret.resources in values.yaml (defaults match postgresql.wait.resources: 25m/64Mi requests, 100m/128Mi limits — the container just runs `wc -c` + `grep -Eq`, so 25m/64Mi is generous) and render the block in deployment.yaml via the same pattern the wait-for init containers use. Fixes broken smoke deploy on master post PR #58 merge. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-#58 hotfix (round 3).
dev-yuzishunamespace's ResourceQuota rejects the Deployment because the newassert-cluster-secretinit container from Phase E3 has no cpu/memory requests+limits.Adds
cluster.assertSecret.resourcesin values.yaml (defaults 25m/64Mi req, 100m/128Mi lim — matchespostgresql.wait.resources) and renders in deployment.yaml.Fixes:
Chart tests pass. Local render verified block appears under init container.
🤖 Generated with Claude Code