fix: add pre-commit hooks, fix all lint and type errors#4
Merged
alex-jadecli merged 3 commits intomainfrom Apr 12, 2026
Merged
Conversation
- Add .pre-commit-config.yaml with: trailing-whitespace, end-of-file-fixer, check-yaml, check-added-large-files, ruff (lint + format), mypy, pytest (pre-push) - Fix 53 E501 line-too-long errors via per-file-ignores for skill scripts - Fix F401 unused numpy import in embed_tools.py - Fix E721 type comparison in schema_diff.py (type() != -> is not) - Fix B017 blind Exception catches in test_cli.py (-> ValidationError) - Fix all 21 mypy errors: add dict[str, Any] type params across 7 model files, fix spider Failure type narrowing with proper type: ignore comments - Apply ruff-format to 20 files for consistent formatting - CI workflow: replace separate lint/typecheck job with pre-commit/action - SessionStart hook: run make install + make install-dev, auto-install pre-commit hooks - Add pre-commit to dev dependencies - Set line-length=120 in claude_code_models subpackage https://claude.ai/code/session_012Fo1zDkFscGkGriGfyXALE
setup-uv enable-cache expects a uv.lock file for cache key generation. This project uses pip install, not uv sync, so no lockfile exists. Remove enable-cache to unblock all CI jobs. https://claude.ai/code/session_012Fo1zDkFscGkGriGfyXALE
Add claude.yml (@claude mention handler) and claude-code-review.yml (automatic PR review with code-review plugin) from PR #5. Remove inline claude-code-review job from ci.yml since the dedicated workflow replaces it. https://claude.ai/code/session_012Fo1zDkFscGkGriGfyXALE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.pre-commit-config.yamlwith 8 hooks: trailing-whitespace, end-of-file-fixer, check-yaml, check-added-large-files, ruff (lint + format), mypy, pytest (pre-push)dict[str, Any]type params across 7 model files, fix spiderFailuretype narrowingpre-commit/actionso local and CI run identical checksmake install+make install-dev, auto-install pre-commit git hookspre-commit>=4.0to dev dependenciesline-length=120inclaude_code_modelssubpackage to match root configTest plan
pre-commit run --all-filespasses all 8 hookspython -m mypy src/agentwarehouses/— 0 errors (was 43)ruff check .— all checks passed (was 53 errors)python -m pytest tests/ -x -q --timeout=30— 95 passedgit pushhttps://claude.ai/code/session_012Fo1zDkFscGkGriGfyXALE