Merged
Conversation
Added a publish-subscribe module to allow functions in different parts of the application to communicate in a "loosely-coupled," manner. The impetus was to allow the reaper co-routine to take events out of the index, change their state to "expired", and send them back through the streams. This patch updates the datagram handler function to use the pubsub pattern to send recieved events into the stream-processing functions instead of processing them itself. The reaper process then just has to publish events to the same listener topic.
We should ensure that when subscribe is called that the listener will be added to the topic before any further events are published to that topic.
Collaborator
|
Well, it is missing tests. But aside from that, it looks simple, but does the job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a naive and ludicrously simple pub-sub system. It's so simple I fear I must be doing something wrong. But it works quite well so...