Capturesnaps#9
Merged
Merged
Conversation
added 6 commits
February 21, 2015 22:27
…current directory
…into capturesnaps
Owner
|
Hey, I think it makes sense to keep get_snaps() as light as possible and not include additional functionality, but I'd love to add the CaptureBot example -- can you submit a pull request with just that instead? Thanks! |
Author
|
If I remove the functionality from get_snaps() then the example won't work. Are you okay with that? I could make it read the snap.file inside the capturebot object, but that would be a hacky way to do it |
Owner
|
I was thinking keeping the class CaptureBot(SnapchatBot):
def on_snap(self, sender, snap):
save_snap(sender, snap)& modifying |
Author
|
Ahh, of course. Added another commit with all the functionality in save_snaps |
Owner
|
Looks great, thanks! |
Contributor
|
This is awesome, thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.