Skip to content

Capturesnaps#9

Merged
agermanidis merged 8 commits into
agermanidis:masterfrom
EthanBlackburn:capturesnaps
Feb 22, 2015
Merged

Capturesnaps#9
agermanidis merged 8 commits into
agermanidis:masterfrom
EthanBlackburn:capturesnaps

Conversation

@EthanBlackburn
Copy link
Copy Markdown

No description provided.

@agermanidis
Copy link
Copy Markdown
Owner

Hey, I think it makes sense to keep get_snaps() as light as possible and not include additional functionality, but I'd love to add the CaptureBot example -- can you submit a pull request with just that instead? Thanks!

@EthanBlackburn
Copy link
Copy Markdown
Author

If I remove the functionality from get_snaps() then the example won't work. Are you okay with that? I could make it read the snap.file inside the capturebot object, but that would be a hacky way to do it

@agermanidis
Copy link
Copy Markdown
Owner

I was thinking keeping the save_snap util function and then doing something like this for the Capture Bot:

class CaptureBot(SnapchatBot):
     def on_snap(self, sender, snap):
         save_snap(sender, snap)

& modifying save_snap appropriately for that to work.

@EthanBlackburn
Copy link
Copy Markdown
Author

Ahh, of course. Added another commit with all the functionality in save_snaps

agermanidis added a commit that referenced this pull request Feb 22, 2015
@agermanidis agermanidis merged commit 919f63a into agermanidis:master Feb 22, 2015
@agermanidis
Copy link
Copy Markdown
Owner

Looks great, thanks!

@N07070
Copy link
Copy Markdown
Contributor

N07070 commented Feb 22, 2015

This is awesome, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants