feat(companion): implement multi-byte path hash encoding and management#2
Merged
agessaman merged 1 commit intodev-companion-v2from Mar 6, 2026
Merged
Conversation
Owner
agessaman
commented
Mar 6, 2026
agessaman
commented
- Introduced support for multi-byte path lengths in CompanionBase, allowing for 1-byte, 2-byte, and 3-byte hash sizes.
- Added methods to set and apply path hash mode, ensuring proper encoding in originated packets.
- Updated constants and packet handling to accommodate new path length encoding, enhancing compatibility with firmware.
- Enhanced tests to validate the new path hash functionality and ensure correct behavior across various scenarios.
- Introduced support for multi-byte path lengths in CompanionBase, allowing for 1-byte, 2-byte, and 3-byte hash sizes. - Added methods to set and apply path hash mode, ensuring proper encoding in originated packets. - Updated constants and packet handling to accommodate new path length encoding, enhancing compatibility with firmware. - Enhanced tests to validate the new path hash functionality and ensure correct behavior across various scenarios.
agessaman
added a commit
that referenced
this pull request
Mar 28, 2026
…med - TODO #1 and #2 - Introduced `_pending_ack_crcs` to track pending ACK CRCs in `CompanionBase`, enhancing the handling of confirmed sends. - Refactored `_track_pending_ack` and `_apply_ack` methods to utilize the new `_try_confirm_send` method for improved clarity and functionality. - Updated `CompanionRadio` to clear pending ACKs upon key import and added an ACK received listener to the dispatcher for better integration. - Enhanced the dispatcher to support asynchronous ACK handling, ensuring efficient processing of received ACKs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.