Merged
Conversation
Replace former client/db fields with a ProofBackend enum and unify backend initialization and usage. Update aggregation vkey extraction, FEP request handling to pattern-match on the backend (Database vs Grpc), and adjust tests and constructors to the new API.
Add agglayer-interop-types dependency. Replace ad-hoc debug prints with structured error logging and propagate errors using map_err. Clone backend when matching Database to avoid borrow issues and use sp1_fast-wrapped deserialization to prevent panics.
vcastellm
requested review from
Ekleog-Polygon,
Freyskeyd,
adria0pol,
atanmarko,
hadjiszs,
iljakuklic and
polykeith
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new utility function for waiting on proof completion in the
ProposerDBClient, adds a new dependency for interoperability, and refactors theProposerServicetest setup to use a constructor method for improved clarity and maintainability.Core functionality improvements:
wait_for_proof_completiontoProposerDBClientthat polls for a proof's completion, handling retries and error cases such as failure, cancellation, or timeout.Dependency updates:
agglayer-interop-typesas a workspace dependency incrates/proposer-service/Cargo.tomlto improve interoperability with other ecosystem components.Test and codebase refactoring:
ProposerServicetest setup to use theProposerService::newconstructor and theProofBackend::Grpcvariant, replacing direct struct initialization for better encapsulation and maintainability incrates/proposer-service/src/tests/mod.rs. [1] [2]ProofBackendto the imports in the test module to support the new test setup.