Password generator options length not honoured when saving a new Login

[jbrayton]

I am calling storeLoginForURLString:... with this passwordGenerationOptions dictionary:

NSDictionary *passwordGenerationOptions = @{
                                            AppExtensionGeneratedPasswordMinLengthKey: @(20),
                                            AppExtensionGeneratedPasswordMaxLengthKey: @(64)
                                            };

The resulting default 1Password entry has a password with twelve characters. The Length slider is set to 4.

[radazzouz]

Hi @jbrayton,

Thank you for opening this issue 😄

We haven't implemented this in 1Password yet. The improvement is bound to come really soon. In a future update of 1Password beta.

Cheers!

[radazzouz]

Hi @jbrayton,

We just merged PR #56 and we also just release 1Password 4.6b14.

Please let us know whether the password generator's min and max lengths are now honored.

I'm closing the issue for now.

Regards,

[evanwalsh]

@radazzouz I'm seeing this issue in 1.2. It's not respecting my minimum or my maximum. Here's what my code looks like:

NSDictionary *passwordGenerationOptions = @{
        AppExtensionGeneratedPasswordMinLengthKey: @(8),
        AppExtensionGeneratedPasswordMaxLengthKey: @(40)
    };

    [[OnePasswordExtension sharedExtension] storeLoginForURLString:@"https://harvestapp.com"
                                                      loginDetails:newLoginDetails
                                         passwordGenerationOptions:passwordGenerationOptions
                                                 forViewController:self
                                                            sender:sender
                                                        completion:^(NSDictionary *loginDict, NSError *error) {
                                                            // HANDLE 1PASSWORD STUFF HERE
                                                        }];

What am I doing wrong?

[radazzouz]

Hi @evanwalsh,

Thanks for the heads up! You are right indeed! The funny part is that I discovered this very issue earlier today while working on issue #36.

This is a 1Password bug (a recent regression) and not an App Extension API bug, so you don't need to change anything in your code. I just filed an internal bug and we'll get to it shortly. I will also re-open this issue.

Please let me know if there's anything else I can do to help 😉

Cheers!

ref: OPI-2697

[radazzouz]

In PR #217 and in 1Password 5.5 we improved the password generator options as follows

    NSDictionary *passwordGenerationOptions = @{
                                                // The minimum password length can be 4 or more.
                                                AppExtensionGeneratedPasswordMinLengthKey: @(8),

                                                // The maximum password length can be 50 or less.
                                                AppExtensionGeneratedPasswordMaxLengthKey: @(30),

                                                // If YES, the 1Password will guarantee that the generated password will contain at least one digit (number between 0 and 9). Passing NO will not exclude digits from the generated password.
                                                AppExtensionGeneratedPasswordRequireDigitsKey: @(YES),

                                                // If YES, the 1Password will guarantee that the generated password will contain at least one symbol (See the list bellow). Passing NO with will exclude symbols from the generated password.
                                                AppExtensionGeneratedPasswordRequireSymbolsKey: @(YES),

                                                // Here are all the symbols available in the the 1Password Password Generator:
                                                // !@#$%^&*()_-+=|[]{}'\";.,>?/~`
                                                // The string for AppExtensionGeneratedPasswordForbiddenCharactersKey should contain the symbols and characters that you wish 1Password to exclude from the generated password.

                                                AppExtensionGeneratedPasswordForbiddenCharactersKey: @"!@#$%/0lIO"
                                                };

Please make sure you take a peek at the save Login and change password capabilities.