Skip to content

Add types, update mappers to throw better errors, remove dead code, add logic to guard against incorrect mappings#137

Merged
5PK merged 6 commits into
mainfrom
PROD-1321
May 25, 2026
Merged

Add types, update mappers to throw better errors, remove dead code, add logic to guard against incorrect mappings#137
5PK merged 6 commits into
mainfrom
PROD-1321

Conversation

@5PK
Copy link
Copy Markdown
Collaborator

@5PK 5PK commented May 21, 2026

  • strongly type the batch item for ease of use
  • split extractBatchResults into typed extractContentBatchResults and extractPageBatchResults
  • update mappers to throw an error if the mappings are invalid or will be invalid
  • formatting, add a check for container mapping validity
  • remove dead code. failedItems field never got populated anyway.
  • add logic in the content mapper to guard against incorrect mappings.

- split extractBatchResults into typed extractContentBatchResults and extractPageBatchResults
- update mappers to throw an error if the mappings are invalid or will be invalid
- formatting, add a check for container mapping validity
- remove dead code. failedItems field never got populated anyway.
- add logic in the content mapper to guard against incorrect mappings.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@5PK 5PK changed the title - strongly type the batch item for ease of use Add types, update mappers to throw better errors, remove dead code, add logic to guard against incorrect mappings May 21, 2026
@5PK
Copy link
Copy Markdown
Collaborator Author

5PK commented May 25, 2026

Added additional fixes to handle the overwrite flag

@5PK 5PK merged commit 4da362d into main May 25, 2026
1 check passed
@5PK 5PK deleted the PROD-1321 branch May 25, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants