Create /dev/null in new root to prevent hangs#3
Merged
agners merged 1 commit intoagners:masterfrom Apr 17, 2020
Merged
Conversation
gnupg post install script does "dirmngr </dev/null &>/dev/null". Since "pacman -r" does not mount any filesystems but it does chroot into the new root, /dev/null does not exist, making the script hang forever.
Owner
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gnupg post install script does
dirmngr </dev/null &>/dev/null.Since
pacman -rdoes not mount any filesystems but it does chroot into the new root to install the new packages,/dev/nulldoes not exist, making the script hang forever.This patch creates
$newroot/dev/nullbefore runningpacman, and then removes it to prevent any issues.