Jose/fix dashboard error #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following bug:
This PR moves Zendesk_Zendesk_Adminhtml_ZendeskController::storeDependenciesInCachedRegistry() to a helper class, making it accessible to other classes.
The zendesk grid on the magento dashboard depends on Mage::registry('zendesk_users') to have an array value. Apparently this isn't being set on the dashboard, since storeDependenciesInCachedRegistry() is exclusively on the controller class.
/cc @jwswj @miogalang @mmolina
References
Risks