Merged
Conversation
This was
linked to
issues
Mar 27, 2026
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / verify-proto (pull_request).
|
d1b014d to
896e88a
Compare
ramizpolic
reviewed
Mar 27, 2026
ramizpolic
reviewed
Mar 30, 2026
ramizpolic
reviewed
Mar 30, 2026
ramizpolic
reviewed
Mar 30, 2026
ramizpolic
reviewed
Mar 30, 2026
ramizpolic
reviewed
Mar 30, 2026
ramizpolic
reviewed
Mar 30, 2026
0a5a930 to
62617b0
Compare
ramizpolic
reviewed
Mar 30, 2026
| } | ||
|
|
||
| ginkgo.GinkgoWriter.Printf("Waiting for daemon at %s...\n", addr) | ||
| gomega.Expect(waitForServerReady(addr)).To(gomega.Succeed()) |
Member
There was a problem hiding this comment.
nit: we dont need to redeclare a new method for checking running state, simply reuse from utils package github.com/agntcy/dir/tests/e2e/shared/utils
Suggested change
| gomega.Expect(waitForServerReady(addr)).To(gomega.Succeed()) | |
| ginkgo.GinkgoWriter.Printf("Waiting for Directory daemon at %s...\n", addr) | |
| gomega.Eventually(utils.IsGrpcServerReady). | |
| WithArguments(addr). | |
| WithPolling(readyPollInterval). | |
| WithTimeout(readyTimeout). | |
| Should(gomega.Succeed()) | |
| ginkgo.GinkgoWriter.Printf("Directory apiserver is daemon at %s\n", addr) |
…package Signed-off-by: Catarina Paralta <clouropa@cisco.com>
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
…rectory daemon Signed-off-by: Catarina Paralta <clouropa@cisco.com>
…local store Signed-off-by: Catarina Paralta <clouropa@cisco.com>
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
a0950c4 to
aeb6112
Compare
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
aeb6112 to
f33c579
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
dirctl daemon start|stop|status— a self-contained local directory server that bundles the gRPC apiserver and reconciler in one process with embedded SQLite and filesystem OCI store.dirctl daemonsubcommands (start,stop,status) with PID file management,--data-diroverride, and SIGTERM graceful shutdownserver.Start()and refactorreconciler/service.New()to accept DB/store/config so both can be embedded by the daemon*remote.Repositorytoregistry.TagListerinterface to support local OCI storeswalkReferrersViaPredecessorsfallback in OCI store so sign/verify work on local layout stores without the Referrers APItest:e2e:daemonTaskfile task and Ginkgo test suite covering push, pull, sign, and verify against a running daemon