Skip to content

refactor(importer): remove#1401

Merged
adamtagscherer merged 4 commits into
mainfrom
refactor/remove-importer
Apr 23, 2026
Merged

refactor(importer): remove#1401
adamtagscherer merged 4 commits into
mainfrom
refactor/remove-importer

Conversation

@adamtagscherer
Copy link
Copy Markdown
Member

@adamtagscherer adamtagscherer commented Apr 22, 2026

This PR removes the importer module from this project and uses the other one in the https://github.com/agntcy/dir-importer repo.

Test import MCP records workflow run on this branch: https://github.com/agntcy/dir/actions/runs/24823681772

@adamtagscherer adamtagscherer added this to the DIR v1.3 milestone Apr 22, 2026
@adamtagscherer adamtagscherer self-assigned this Apr 22, 2026
@adamtagscherer adamtagscherer requested a review from a team as a code owner April 22, 2026 15:13
@adamtagscherer adamtagscherer added go Pull requests that update go code area/importer labels Apr 22, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in Discovery Apr 22, 2026
@github-actions github-actions Bot added the size/XL Denotes a PR that changes 2000+ lines label Apr 22, 2026
@adamtagscherer adamtagscherer changed the title refactor: remove importer refactor(importer): remove Apr 22, 2026
@adamtagscherer adamtagscherer force-pushed the refactor/remove-importer branch from bf500d8 to a102a54 Compare April 22, 2026 15:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

The latest Buf updates on your PR. Results from workflow Buf CI / verify-proto (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped⏩ skipped✅ passedApr 23, 2026, 12:12 PM

@lgecse lgecse moved this from Backlog to Pending review in Discovery Apr 23, 2026
@adamtagscherer adamtagscherer linked an issue Apr 23, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Member

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
@adamtagscherer adamtagscherer force-pushed the refactor/remove-importer branch from 4bc410a to fb4feeb Compare April 23, 2026 12:11
@adamtagscherer adamtagscherer merged commit 345335f into main Apr 23, 2026
37 checks passed
@adamtagscherer adamtagscherer deleted the refactor/remove-importer branch April 23, 2026 12:32
keraron pushed a commit to keraron/dir that referenced this pull request May 5, 2026
* refactor: remove importer

Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>

* refactor: remove importer

Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>

* refactor: remove importer

Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>

* refactor: remove importer

Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>

---------

Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Aron Kerekes <arkereke@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/importer go Pull requests that update go code size/XL Denotes a PR that changes 2000+ lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Wire in the importer from the new repo

4 participants