refactor(reconciler): use fork to execute regsync#1428
Merged
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / verify-proto (pull_request).
|
csirmazbendeguz
force-pushed
the
refactor/regsync
branch
3 times, most recently
from
a5a3382 to
275d049
Compare
csirmazbendeguz
force-pushed
the
refactor/regsync
branch
2 times, most recently
from
01bda6f to
9fc785e
Compare
ramizpolic
reviewed
Apr 29, 2026
csirmazbendeguz
force-pushed
the
refactor/regsync
branch
2 times, most recently
from
1a58e8f to
b02492a
Compare
ramizpolic
approved these changes
Apr 29, 2026
Member
|
@csirmazbendeguz there are places in the code that are still downloading (taskfile, bake, etc) and using regsync. can we remove those as well? |
Contributor
Author
yes of course, gotta remove it from the Dockerfile |
csirmazbendeguz
force-pushed
the
refactor/regsync
branch
from
b02492a to
6812734
Compare
github-actions
Bot
added
size/S
ramizpolic
reviewed
Apr 29, 2026
Comment on lines
16
to
17
| // DefaultConfigPath is the default path for the regsync configuration file. | ||
| DefaultConfigPath = "/etc/regsync/regsync.yaml" |
Contributor
Author
There was a problem hiding this comment.
I think this may be leftover from development... it's not used anywhere (not even in main). If you agree, we can address this in a different PR, I feel like it's out of scope for this one
ramizpolic
reviewed
Apr 29, 2026
| variable "IMAGE_TAG" { default = "v0.1.0-rc" } | ||
| variable "BUILD_LDFLAGS" { default = "-s -w -extldflags -static" } | ||
| variable "IMAGE_NAME_SUFFIX" { default = "" } | ||
| variable "REGSYNC_VERSION" { default = "v0.11.1" } |
Member
There was a problem hiding this comment.
i think there are other places in the code (Taskfile) defining this as well
csirmazbendeguz
force-pushed
the
refactor/regsync
branch
2 times, most recently
from
8f6b4af to
24bd917
Compare
Signed-off-by: Bendegúz Csirmaz <csirmazbendeguz@gmail.com>
csirmazbendeguz
force-pushed
the
refactor/regsync
branch
from
24bd917 to
5f15703
Compare
2 tasks
keraron
pushed a commit
to keraron/dir
that referenced
this pull request
May 5, 2026
Signed-off-by: Bendegúz Csirmaz <csirmazbendeguz@gmail.com> Signed-off-by: Aron Kerekes <arkereke@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding my fork of regclient: https://github.com/csirmazbendeguz/regclient , so we can remove the regsync binary and use regsync like a Go library instead
we should find a way to contribute this to regclient so we can remove my fork in the future. adding this so it's done for the release