Skip to content

test(dir): fix naming test#1491

Merged
adamtagscherer merged 1 commit into
mainfrom
test/fix-naming-test
May 12, 2026
Merged

test(dir): fix naming test#1491
adamtagscherer merged 1 commit into
mainfrom
test/fix-naming-test

Conversation

@adamtagscherer
Copy link
Copy Markdown
Member

@adamtagscherer adamtagscherer commented May 11, 2026

This PR fixes: #1433

Test run from CI:

...
Running dirctl e2e tests for DNS name verification naming verification workflow should push a record with DNS-prefixed name
/home/runner/work/dir/dir/tests/e2e/local/09_naming_test.go:215
• [0.037 seconds]
------------------------------
Running dirctl e2e tests for DNS name verification naming verification workflow should sign the record with cosign key
/home/runner/work/dir/dir/tests/e2e/local/09_naming_test.go:222
• [5.224 seconds]
------------------------------
Running dirctl e2e tests for DNS name verification naming verification workflow should verify signature is trusted
/home/runner/work/dir/dir/tests/e2e/local/09_naming_test.go:229
• [0.017 seconds]
------------------------------
Running dirctl e2e tests for DNS name verification naming verification workflow should check naming verification status by CID
/home/runner/work/dir/dir/tests/e2e/local/09_naming_test.go:235
• [0.009 seconds]
------------------------------
Running dirctl e2e tests for DNS name verification naming verification workflow should check naming verification status by name
/home/runner/work/dir/dir/tests/e2e/local/09_naming_test.go:239
• [0.080 seconds]
------------------------------
Running dirctl e2e tests for DNS name verification naming verification workflow should check naming verification status by name with version
/home/runner/work/dir/dir/tests/e2e/local/09_naming_test.go:243
• [0.038 seconds]
...

Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
@adamtagscherer adamtagscherer added this to the DIR v1.4 milestone May 11, 2026
@adamtagscherer adamtagscherer self-assigned this May 11, 2026
@adamtagscherer adamtagscherer requested a review from a team as a code owner May 11, 2026 15:04
@adamtagscherer adamtagscherer added the go Pull requests that update go code label May 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

The latest Buf updates on your PR. Results from workflow Buf CI / verify-proto (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped⏩ skipped✅ passedMay 11, 2026, 3:05 PM

@github-actions github-actions Bot added the size/S Denotes a PR that changes 50-199 lines label May 11, 2026
@adamtagscherer adamtagscherer changed the title test: fix naming test test(dir): fix naming test May 11, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@adamtagscherer adamtagscherer merged commit 6f1cd28 into main May 12, 2026
40 of 41 checks passed
@adamtagscherer adamtagscherer deleted the test/fix-naming-test branch May 12, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update go code size/S Denotes a PR that changes 50-199 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: E2E test case does not test dns-validation

3 participants