Skip to content

Comments

fix(dir/sdk): fix JS SDK example and add example validation to CI#794

Merged
paralta merged 3 commits intomainfrom
bug/792
Jan 7, 2026
Merged

fix(dir/sdk): fix JS SDK example and add example validation to CI#794
paralta merged 3 commits intomainfrom
bug/792

Conversation

@paralta
Copy link
Member

@paralta paralta commented Jan 7, 2026

Fixes #792

The JavaScript SDK example was using the outdated client.search() method which no longer exists. This PR fixes the example and adds CI validation to prevent similar issues in the future.

Signed-off-by: Catarina Paralta <clouropa@cisco.com>
… Taskfile.yml

Signed-off-by: Catarina Paralta <clouropa@cisco.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

The latest Buf updates on your PR. Results from workflow Buf CI / verify-proto (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped⏩ skipped✅ passedJan 7, 2026, 12:32 PM

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-49 lines label Jan 7, 2026
…n example

Signed-off-by: Catarina Paralta <clouropa@cisco.com>
@paralta paralta marked this pull request as ready for review January 7, 2026 13:15
@paralta paralta requested a review from a team as a code owner January 7, 2026 13:15
@paralta paralta merged commit c50c2e3 into main Jan 7, 2026
44 of 45 checks passed
@paralta paralta deleted the bug/792 branch January 7, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-49 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Js example bugs

2 participants