fix: remove finalize keyword from bindings#1237
Merged
Merged
Conversation
Signed-off-by: Mauro Sardara <msardara@cisco.com>
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
lgecse
approved these changes
Feb 17, 2026
Merged
msardara
pushed a commit
that referenced
this pull request
Feb 27, 2026
## 🤖 New release * `agntcy-slim-auth`: 0.5.0 -> 0.5.1 (✓ API compatible changes) * `agntcy-slim-config`: 0.6.2 -> 0.6.3 (✓ API compatible changes) * `agntcy-slim-tracing`: 0.3.3 -> 0.3.4 (✓ API compatible changes) * `agntcy-slim-datapath`: 0.11.3 -> 0.11.4 (✓ API compatible changes) * `agntcy-slim-controller`: 0.4.7 -> 0.4.8 (✓ API compatible changes) * `agntcy-slim-service`: 0.8.6 -> 0.8.7 (✓ API compatible changes) * `agntcy-slim`: 1.0.2 -> 1.1.0 (✓ API compatible changes) * `agntcy-slim-bindings`: 1.1.1 -> 1.2.0 (✓ API compatible changes) * `agntcy-slimctl`: 1.2.0 * `agntcy-protoc-slimrpc-plugin`: 1.0.2 -> 1.1.0 (✓ API compatible changes) * `agntcy-slim-mls`: 0.1.9 -> 0.1.10 * `agntcy-slim-session`: 0.1.6 -> 0.1.7 <details><summary><i><b>Changelog</b></i></summary><p> ## `agntcy-slim-auth` <blockquote> ## [0.5.1](slim-auth-v0.5.0...slim-auth-v0.5.1) - 2026-02-27 ### Added - *(data-plane)* port slimctl to Rust ([#1255](#1255)) </blockquote> ## `agntcy-slim-config` <blockquote> ## [0.6.3](slim-config-v0.6.2...slim-config-v0.6.3) - 2026-02-27 ### Added - remove go implementation of slimctl and refactor workflows ([#1276](#1276)) </blockquote> ## `agntcy-slim-tracing` <blockquote> ## [0.3.4](slim-tracing-v0.3.3...slim-tracing-v0.3.4) - 2026-02-27 ### Added - remove go implementation of slimctl and refactor workflows ([#1276](#1276)) </blockquote> ## `agntcy-slim-datapath` <blockquote> ## [0.11.4](slim-datapath-v0.11.3...slim-datapath-v0.11.4) - 2026-02-27 ### Added - add subscribe/unsubscribe ack handling ([#1111](#1111)) </blockquote> ## `agntcy-slim-controller` <blockquote> ## [0.4.8](slim-controller-v0.4.7...slim-controller-v0.4.8) - 2026-02-27 ### Added - remove go implementation of slimctl and refactor workflows ([#1276](#1276)) - add subscribe/unsubscribe ack handling ([#1111](#1111)) </blockquote> ## `agntcy-slim-service` <blockquote> ## [0.8.7](slim-service-v0.8.6...slim-service-v0.8.7) - 2026-02-27 ### Added - remove go implementation of slimctl and refactor workflows ([#1276](#1276)) - add subscribe/unsubscribe ack handling ([#1111](#1111)) </blockquote> ## `agntcy-slim` <blockquote> ## [1.1.0](slim-v1.0.2...slim-v1.1.0) - 2026-02-27 ### Added - remove go implementation of slimctl and refactor workflows ([#1276](#1276)) </blockquote> ## `agntcy-slim-bindings` <blockquote> ## [1.2.0](slim-bindings-v1.1.1...slim-bindings-v1.2.0) - 2026-02-27 ### Added - slim bindings kotlin ([#1198](#1198)) - remove go implementation of slimctl and refactor workflows ([#1276](#1276)) - Create helper to convert string name to slim_bindings.Name ([#1251](#1251)) - improve default values for exposed Client and Server config ([#1244](#1244)) ### Fixed - *(slimctl)* improve startup error reporting ([#1248](#1248)) - remove finalize keyword from bindings ([#1237](#1237)) </blockquote> ## `agntcy-slimctl` <blockquote> ## [1.2.0](https://github.com/agntcy/slim/releases/tag/slimctl-v1.2.0) - 2026-02-27 ### Added - remove go implementation of slimctl and refactor workflows ([#1276](#1276)) - *(data-plane)* port slimctl to Rust ([#1255](#1255)) ### Fixed - bump slimctl version ([#1286](#1286)) </blockquote> ## `agntcy-protoc-slimrpc-plugin` <blockquote> ## [1.1.0](protoc-slimrpc-plugin-v1.0.2...protoc-slimrpc-plugin-v1.1.0) - 2026-02-27 ### Added - *(slimrpc-compiler)* add types_import/types_alias params to Go plugin ([#1274](#1274)) ### Fixed - remove finalize keyword from bindings ([#1237](#1237)) </blockquote> ## `agntcy-slim-mls` <blockquote> ## [0.1.10](slim-mls-v0.1.9...slim-mls-v0.1.10) - 2026-02-27 ### Other - updated the following local packages: agntcy-slim-auth, agntcy-slim-datapath </blockquote> ## `agntcy-slim-session` <blockquote> ## [0.1.7](slim-session-v0.1.6...slim-session-v0.1.7) - 2026-02-27 ### Other - updated the following local packages: agntcy-slim-auth, agntcy-slim-datapath, agntcy-slim-mls </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1240
Description
Finalize is a keyword in some languages (e.g. c#)
so we cannot use it as method name.
Refactor it to use finalize_async*
Type of Change
Checklist