Skip to content

PWA#239

Merged
agritheory merged 4 commits intomobile_v15from
mobile_v15-pwa-home-screen
Dec 5, 2024
Merged

PWA#239
agritheory merged 4 commits intomobile_v15from
mobile_v15-pwa-home-screen

Conversation

@lauty95
Copy link
Copy Markdown
Collaborator

@lauty95 lauty95 commented Nov 29, 2024

I installed vite-plugin-pwa as a dev dependency and used it to set up the files that need to be cached

To tested it I used ngrok

ngrok http 8000

and then i just get in with the url that show in the console
Screenshot 2024-11-29 at 11 51 24 AM

This is required to install a PWA (that the url is in https)

clideo_editor_26a44e2c3558489598ade7d7d966e225.mp4

@lauty95 lauty95 requested review from Alchez and agritheory November 29, 2024 14:55
@lauty95 lauty95 linked an issue Nov 29, 2024 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 29, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py10100% 
beam
   barcodes.py311358%18, 27, 29, 32, 43–44, 46–47, 52–54, 58–59
   handling_unit.py813754%25, 31, 63–65, 83, 94–95, 101–102, 104–105, 107–108, 110–111, 113, 115–118, 120–122, 124, 126, 128–129, 134, 136, 140, 142–143, 146, 148–149, 157
   printing.py61610%4–6, 8, 11–12, 15–16, 18–21, 24–25, 34–45, 47–54, 58–59, 61–62, 71–75, 78–79, 85–87, 90–91, 94–95, 97–99, 101–102, 104, 109, 111–112
beam/demand
   demand.py3222891%51, 66, 123, 209, 243, 290, 293, 463–464, 483–485, 490–491, 493, 495–497, 499, 543, 621, 625, 662, 667, 674, 695–696, 708
   receiving.py111496%79, 131, 173, 214
   sqlite.py59198%40
   utils.py59689%56, 67, 73–75, 83
beam/doctype/beam_mobile_route
   beam_mobile_route.py30100% 
beam/doctype/beam_settings
   beam_settings.py352042%31–33, 44, 55–56, 59–60, 62, 69, 74–77, 85–87, 91–93
beam/doctype/handling_unit
   __init__.py9366%12–14
   handling_unit.py150100% 
beam/doctype/warehouse_types
   warehouse_types.py30100% 
beam/overrides
   sales_order.py10640%11–16
   stock_entry.py671774%61–62, 67–74, 80–81, 97, 112, 129, 132–133
   work_order.py10280%14, 16
beam/report/demand_map
   demand_map.py35350%4–5, 7–8, 11–12, 15–16, 103–111, 127, 129–143, 146–147
beam/report/handling_unit_traceability
   handling_unit_traceability.py44440%4–6, 9–11, 30–32, 34–35, 37–38, 41–42, 45–46, 48–49, 51–52, 54–55, 57, 63–65, 67–69, 71, 74–77, 79–81, 83–86, 89–90
beam/scan
   __init__.py1281985%21, 25, 30, 38, 70, 117–118, 128, 130–131, 135, 139–140, 143, 175, 204, 206, 224, 227
   config.py26260%4, 6, 9–17, 19–21, 23–26, 28–30, 32–35, 37
www/beam
   __init__.py14140%4–7, 10–19
   index.py770%4, 6, 9–13
TOTAL113134369% 

@agritheory
Copy link
Copy Markdown
Owner

This looks great! I think I'm going to provide an icon that looks more like an application. @lauty95 Can you look into the TWA workflow to remove the URL bar on top? https://stackoverflow.com/a/63079169

@lauty95
Copy link
Copy Markdown
Collaborator Author

lauty95 commented Dec 2, 2024

@agritheory
I really tried to remove the top bar, but I couldn't. I spent a lot of time on it and thought this issue would be easy when I started, but since it's not a priority, I made this PR to share my progress and move on to issue #220, which I believe is more important.

However, I’ll check the Stack Overflow discussion and test other solutions.
Thanks!

@agritheory
Copy link
Copy Markdown
Owner

@Alchez Can you take a look at this config to remove the header bar? @lauty95 needs a hand.

@Alchez
Copy link
Copy Markdown
Collaborator

Alchez commented Dec 5, 2024

@agritheory @lauty95 I've added some <meta> tags that should help resolve the PWA without an address bar. Can you build the latest change and try locally as well?

@lauty95
Copy link
Copy Markdown
Collaborator Author

lauty95 commented Dec 5, 2024

@Alchez @agritheory
Amazing! It works!

1205.mov

@agritheory agritheory merged commit d7afe7a into mobile_v15 Dec 5, 2024
@agritheory agritheory deleted the mobile_v15-pwa-home-screen branch December 5, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mobile] PWA/ install to home screen

3 participants