feat: allow re-routing after scan input#246
Merged
Alchez merged 3 commits intomobile_v15from Jan 28, 2025
Merged
Conversation
Owner
Yes, this needs to be refactored (in both the app context and the mobile context) - I've had that comment in there for more than a year now, let's fix it. |
Owner
|
No issues with multiple reinstalls on this branch |
Alchez
commented
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature changes:
routekey in the hook definition that will leave the responsibility of defining the target route to the app itself, considering they have the context on the built routes.Additional changes:
Update test setup to exclude account numbers from account name@agritheory it seems like creating production plans is failing during test setup (on frappe 15.53.0 and erpnext 15.49.3). I'm not sure how to fix it, but here's the traceback:Traceback