Add completed_qty to test fixtures

[lauty95]

ERPNext has updated recently: frappe/erpnext#48745

If you try to execute bench execute 'beam.tests.setup.before_test' with ERPNext updated to v15.71.1, it will throw an error:

erpnext.manufacturing.doctype.job_card.job_card.OperationSequenceError: Job Card PO-JOB00002: As per the sequence of the operations in the work order MFG-WO-2025-00001, complete the operation Gather Pie Filling Ingredients before the operation Cook Pie Filling Operation.

This error occurs because Work Order has a new function,validate_operations_sequence:

https://github.com/frappe/erpnext/blob/3825490f0dbbd5530b739e928d012f639b6efafe/erpnext/manufacturing/doctype/work_order/work_order.py#L173

This function assignssequence_id to all operations that don't have one assigned, and then we have this function:

https://github.com/frappe/erpnext/blob/ad45063c76880a443c772a0ea3aa7ab6ca33da3c/erpnext/manufacturing/doctype/job_card/job_card.py#L1032

That function was created one year ago, but it wasn't a problem because it has this condition:

    if not (self.work_order and self.sequence_id):
        return

Since we didn't assignsequence_id to our operations, this validation wasn't a problem.

But this function has a condition before:

	def validate_sequence_id(self):
		if self.is_corrective_job_card:
			return

That is the reason for my change.

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
__init__.py	1	0	100%
beam
barcodes.py	79	34	56%	20, 22, 24, 27, 38–39, 41–42, 47–48, 50–51, 53–55, 61, 71, 79, 86, 89–90, 96–97, 103, 109, 115, 121, 128, 131–134, 136–137
handling_unit.py	81	43	46%	26, 32, 64–66, 69, 72–76, 84, 95–96, 102–103, 105–106, 108–109, 111–112, 114, 116–119, 121–123, 125, 127, 129–130, 135, 137, 141, 143–144, 147, 149–150, 158
printing.py	82	64	21%	18–19, 32–43, 45–48, 57–61, 65–66, 68–69, 78–82, 85–86, 92–94, 101–102, 104–106, 108–109, 111, 116, 118–119, 134–139, 141–150
beam/demand
demand.py	338	94	72%	51, 66, 123, 209, 243, 290, 293, 425–426, 428–429, 432–433, 435, 439–444, 446, 448–449, 452, 457, 459–464, 466, 468, 471, 474, 479, 483–485, 490–491, 493, 495–497, 499, 505, 507–510, 512–515, 517, 519, 522–523, 525–526, 529, 543, 560–561, 563–565, 621, 625, 662, 667, 674, 695–696, 707, 713–729, 853
receiving.py	125	17	86%	79, 131, 173, 214, 244, 249–260
sqlite.py	59	1	98%	40
utils.py	59	7	88%	56, 67, 72–75, 83
beam/doctype/beam_mobile_route
beam_mobile_route.py	3	0	100%
beam/doctype/beam_settings
beam_settings.py	28	17	39%	35–37, 40–41, 43, 50, 55–58, 66–68, 72–74
beam/doctype/handling_unit
__init__.py	9	3	66%	12–14
handling_unit.py	15	0	100%
beam/doctype/warehouse_types
warehouse_types.py	3	0	100%
beam/overrides
sales_order.py	10	6	40%	11–16
stock_entry.py	67	18	73%	61–62, 67–74, 80–81, 97, 112, 123, 129, 132–133
work_order.py	10	2	80%	14, 16
beam/report/demand_map
demand_map.py	35	35	0%	4–5, 7–8, 11–12, 15–16, 103–111, 127, 129–143, 146–147
beam/report/handling_unit_traceability
handling_unit_traceability.py	44	44	0%	4–6, 9–11, 30–32, 34–35, 37–38, 41–42, 45–46, 48–49, 51–52, 54–55, 57, 63–65, 67–69, 71, 74–77, 79–81, 83–86, 89–90
beam/scan
__init__.py	143	28	80%	21, 25, 31, 39, 90, 93–94, 118–119, 129, 131–132, 136, 140–141, 144, 155–156, 160, 181, 185, 214, 216, 235–236, 242, 245, 248
config.py	28	28	0%	4, 6, 9–17, 19–21, 23–26, 28–30, 32–35, 38–39, 41
user_login.py	31	31	0%	4–6, 8, 11–13, 17–19, 21–22, 24–25, 27–29, 31–33, 35–38, 40–45, 47
www/beam
__init__.py	14	14	0%	4–7, 10–19
index.py	7	7	0%	4, 6, 9–13
TOTAL	1271	493	61%

[agritheory]

An alternative is to add sequence id in the fixturing: https://github.com/agritheory/beam/blob/version-14/beam/tests/setup.py#L343

[lauty95]

@agritheory I tested the sorting with order_by:

job_cards = frappe.get_all("Job Card", {"work_order": wo.name}, order_by="sequence_id ASC, creation ASC")

It didn’t solve the issue, so I kept debugging.

The problem comes from validate_sequence_id in job_card.py:L1058:

row.status != "Completed"  # This condition is true, it is not completed yet
row.completed_qty < current_operation_qty  # This is also true, and I believe this is what should be avoided

Case where it fails:

• row.completed_qty = 0
• current_operation_qty = 160.0
• Happens on Job Card PO-JOB00002 from Work Order MFG-WO-2025-00001.

current_operation_qty comes from self.total_completed_qty, which is set in validate_time_logs (L232):

if d.completed_qty and not self.sub_operations:
	self.total_completed_qty += d.completed_qty

This causes the validation to fail.

Fix applied: when adding time_logs to the job card, do not set "completed_qty":

job_card.append(
"time_logs",
{
	#"completed_qty": wo.qty,
	"from_time": start_time,
	"to_time": start_time + datetime.timedelta(minutes=time_in_mins),
	"time_in_mins": time_in_mins,
	"remaining_time_in_mins": time_in_mins,
},
)

Tests still pass, and Playwright tests run without issues.

Not entirely sure if setting "completed_qty" here is ever required.

[agritheory]

I think the completed_qty fix is the correct approach

[agritheory]

@lauty95 Please also cherry pick this for a PR against the version-15 branch