Add support for old-style exception objects.#58
Merged
agronholm merged 1 commit intoagronholm:masterfrom Feb 24, 2017
Merged
Conversation
rhansen
force-pushed
the
old-style-exceptions
branch
2 times, most recently
from
c2315c1 to
ac23179
Compare
rhansen
force-pushed
the
old-style-exceptions
branch
from
ac23179 to
6312c3d
Compare
Python 2 permits raising old-style objects (objects that aren't
instances of the object class). Because these objects are not
instances of BaseException, clauses like 'except BaseException:'
don't catch them.
Add support for handling old-style exception objects by:
* using a class-less 'except:' clause to catch old-style objects
raised by tasks and done callbacks
* using the proper exception object class type when raising a stored
old-type exception during result()
rhansen
force-pushed
the
old-style-exceptions
branch
from
6312c3d to
bc2d107
Compare
Contributor
Author
|
This is sort-of blocking python/typeshed#946. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 2 permits raising old-style objects (objects that aren't instances of the
objectclass). Because these objects are not instances ofBaseException, clauses likeexcept BaseException:don't catch them.Add support for handling old-style exception objects by:
except:clause to catch old-style objects raised by tasks and done callbacksresult()