Fix compatibility with Python 3.15#554
Conversation
|
To prove 3.15 compatibility, this should add 3.15 to the test matrix. |
agronholm
left a comment
There was a problem hiding this comment.
This isn't looking good, but I'm willing to give you a chance to fix it.
- Drop removed debug_override parameter from cache_from_source() call - Accept extra positional args in source_to_code() for new fullname parameter - Guard no_type_check_decorator import behind version check (removed in 3.15) - Add Python 3.15 to the test matrix
|
Please do not force push your changes. If you do, I won't know what you changed in response to my feedback. |
|
I am sorry, I was about to reply in the above conversation. |
|
You added 3.15 to |
|
Alright, getting better! Is there any place where the new |
|
From the 3.15 documentation:
In our case, it could be used in the two |
If you could do that on 3.15, that'd be great. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Looks like I introduced mypy errors with my simplification. Those need to be undone. Otherwise this looks good now! |
|
Thank you for the help! |
Assisted-by: Cursor
Changes
Fixes #.
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) added which would fail without your patchdocs/, in case of behavior changes or newfeatures)
docs/versionhistory.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #999, the entry should look like this:
* Fix big bad boo-boo in the pytest plugin (#999 <https://github.com/agronholm/typeguard/issues/999>_; PR by @yourgithubaccount)If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.