bring database holder back to first round generation#1328
Merged
agrosner merged 2 commits intoagrosner:developfrom Jul 14, 2017
trevjonez:develop
Merged
bring database holder back to first round generation#1328agrosner merged 2 commits intoagrosner:developfrom trevjonez:develop
agrosner merged 2 commits intoagrosner:developfrom
trevjonez:develop
Conversation
|
This PR (I used it as SNAPSHOT from develop branch of @trevjones fork) fixes my issue in production. So, waiting for new release of DBFlow with this PR merged. |
Owner
|
I believe I moved it back to last round due to ManyToMany generated classes needing to generate the holder in last round to collect all of the files. Its fixed because I do a check on the holder before writing it so we shouldnt run into issues where a blank holder gets written. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #979