Irrigation/General Observation report and gatekeeper integration

[JoleVLF]

No description provided.

[fedjo]

Hi @JoleVLF This PR is enormous it is impossible to be reviewed. I suggest you break it in small PRs like

Irrigation report
GO report
GK integration

It would also be nice if the PR is big to add a small description to your PRs so reviewers what to expect

[JoleVLF]

@fedjo It would be difficult to do separating this PRs because commits are tight connected. Also PR is big because 10 files are deleted (unused).

Also one commit is connected to another (fix previous work) so cherry pick this would not be good idea

[fedjo]

@fedjo It would be difficult to do separating this PRs because commits are tight connected. Also PR is big because 10 files are deleted (unused).

Also one commit is connected to another (fix previous work) so cherry pick this would not be good idea

Ahhh :-/ , I do understand. But this does not change that the PR will take ages to be reviewed (40 file changes). Also the bigger the PR the more prone to future errors because something the reviewer may miss. This will create bugfixes etc...

Maybe cherry-picking is not a good idea but since you know the changes it is easier to add them to separate PRs and create new commits.

[JoleVLF]

@fedjo I will do my best, I created this as draft 2 months ago and requests changed, and one change followed another..
Anyway, I will try to do that