Skip to content

fix(tracing): retain turn message id#129

Merged
rowan-stein merged 3 commits into
mainfrom
noa/issue-128
May 26, 2026
Merged

fix(tracing): retain turn message id#129
rowan-stein merged 3 commits into
mainfrom
noa/issue-128

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

@casey-brooks casey-brooks commented May 26, 2026

Summary

  • Keep the active Threads message UUID set on the tracing proxy after message handling returns.
  • Let the next message overwrite agyn.thread.message.id, so delayed async OTLP exports for the current turn remain correlated.
  • Add tracing proxy regression coverage for delayed exports and next-message overwrite behavior.
  • Remove the PR E2E devspace dev deployment patch step because the provisioned stack does not include an agynd ArgoCD app or agynd-agynd deployment.

Closes #128
Closes #130

Test & Lint Summary

  • go test ./... — 193 passed, 0 failed, 0 skipped.
  • go vet ./... — passed with no errors.
  • go build ./... — passed.

CI Note

  • Pushed updates to PR branch noa/issue-128.
  • GitHub Actions did not create new check runs for the latest branch SHA after the push; workflows in this repo do not expose workflow_dispatch, so a manual dispatch rerun is unavailable from the CLI.

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • go test ./... — 193 passed, 0 failed, 0 skipped.
  • go vet ./... — passed with no errors.
  • go build ./... — passed.

noa-lucent
noa-lucent previously approved these changes May 26, 2026
Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The handler no longer clears the active message ID at turn return, the proxy still overwrites it on the next message, and the tracing proxy tests cover retained delayed exports plus overwrite behavior.

Verification: CGO_ENABLED=0 go test ./internal/tracingproxy -count=50 passed. A full go test ./... could not complete in this environment because generated .gen/go/... packages are absent and gcc is not installed for cgo.

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Update for #130

  • Removed the PR E2E devspace dev deployment patch step because the provisioned stack does not include an agynd ArgoCD app or agynd-agynd deployment.
  • The E2E workflow now proceeds directly to the shared agynio/e2e test action, which drives agynd-cli coverage through agent init images instead of patching a missing cluster service.

Test & Lint Summary

  • go test ./... — 193 passed, 0 failed, 0 skipped.
  • go vet ./... — passed with no errors.
  • go build ./... — passed.

@rowan-stein
Copy link
Copy Markdown
Collaborator

E2E run 26428522376 has been stuck in QUEUED for a long time. If Actions runners are blocked/queued org-wide, can a maintainer cancel & re-run, or retrigger checks via / UI once capacity frees? Link: https://github.com/agynio/agynd-cli/actions/runs/26428522376

@rowan-stein rowan-stein merged commit 6a13a2f into main May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants