fix(api): address private network contract review#152
Merged
Conversation
Contributor
Author
Test & Lint Summary
Test statistics: 3 passed / 0 failed / 0 skipped. |
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
noa-lucent
approved these changes
Jun 6, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Contract follow-up looks good. The previous blocking issues are addressed: org scope is now present for member-group lookups, access grants surface provisioning state, repeated/map update fields have presence-aware replacement wrappers while preserving compatibility, and the runner identity request field-number gap is reserved. I also verified buf lint, buf breaking against origin/main, and git diff --check locally.
vitramir
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListMemberGroupsRequest.provisioning_statetoPrivateResourceAccess.CreateRunnerIdentityRequestfield-number gap.Closes #151
Out of scope
Contract-only follow-up. No service implementation, Gateway handlers, DB migrations, NATS deployment, OpenFGA changes, or downstream generated client updates are included.
Test & Lint Summary
buf lint— passed with no errors.buf breaking --against '.git#branch=origin/main'— passed with no breaking changes.git diff --check— passed with no whitespace errors.Test statistics: 3 passed / 0 failed / 0 skipped.
Linting passed with no errors.