Skip to content

feat: add authorization proto#29

Merged
vitramir merged 2 commits intomainfrom
noa/issue-28
Mar 14, 2026
Merged

feat: add authorization proto#29
vitramir merged 2 commits intomainfrom
noa/issue-28

Conversation

@casey-brooks
Copy link
Contributor

Summary

  • add authorization service protobuf definitions

Testing

  • buf lint
  • buf build
  • $(npm config get prefix)/bin/redocly bundle openapi/team/v1/openapi.yaml -o dist/team-v1.yaml
  • $(npm config get prefix)/bin/redocly bundle openapi/files/v1/openapi.yaml -o dist/files-v1.yaml
  • $(npm config get prefix)/bin/redocly bundle openapi/llm/v1/openapi.yaml -o dist/llm-v1.yaml
  • $(npm config get prefix)/bin/spectral lint dist/team-v1.yaml
  • $(npm config get prefix)/bin/spectral lint dist/files-v1.yaml
  • $(npm config get prefix)/bin/spectral lint dist/llm-v1.yaml

Refs #28

@casey-brooks casey-brooks requested a review from a team as a code owner March 14, 2026 11:26
@github-actions
Copy link

github-actions bot commented Mar 14, 2026

The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 14, 2026, 5:13 PM

@casey-brooks
Copy link
Contributor Author

Summary

  • add authorization service protobuf definitions in proto/agynio/api/authorization/v1/authorization.proto

Test & Lint Summary

Commands

  • buf lint
  • buf build
  • $(npm config get prefix)/bin/redocly bundle openapi/team/v1/openapi.yaml -o dist/team-v1.yaml
  • $(npm config get prefix)/bin/redocly bundle openapi/files/v1/openapi.yaml -o dist/files-v1.yaml
  • $(npm config get prefix)/bin/redocly bundle openapi/llm/v1/openapi.yaml -o dist/llm-v1.yaml
  • $(npm config get prefix)/bin/spectral lint dist/team-v1.yaml
  • $(npm config get prefix)/bin/spectral lint dist/files-v1.yaml
  • $(npm config get prefix)/bin/spectral lint dist/llm-v1.yaml

Test stats: passed 0, failed 0, skipped 0 (lint/build only; no test counts reported)

Lint status: buf lint clean; spectral lint warnings only (0 errors).

noa-lucent
noa-lucent previously approved these changes Mar 14, 2026
Copy link

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proto definition is clean, well-structured, and faithfully implements the spec from #28. Package naming, field numbering, go_package, and message layout all follow existing repo conventions and Buf STANDARD lint rules.

One nit left about adding per-RPC doc comments for discoverability — not blocking.

LGTM.

// AuthorizationService is a thin gRPC proxy to OpenFGA.
// It mirrors the OpenFGA runtime API and injects store/model IDs.
service AuthorizationService {
rpc Check(CheckRequest) returns (CheckResponse);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] The issue spec includes a short description for each RPC (e.g. "Can identity X perform relation Y on resource Z? Returns allowed: bool"). Adding per-RPC doc comments would improve discoverability and is consistent with the pattern in chat.proto. Not blocking, but recommended.

  // Can identity X perform relation Y on resource Z?
  rpc Check(CheckRequest) returns (CheckResponse);

  // Multiple checks in a single call. Each check has a correlation_id
  // for matching responses.
  rpc BatchCheck(BatchCheckRequest) returns (BatchCheckResponse);
  ...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added per-RPC doc comments in 2a70be0.

@vitramir vitramir merged commit 858b0c5 into main Mar 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants