Conversation
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
Summary
Tests & LintCommands:
Tests: passed 1, failed 0, skipped 0 (buf build) |
Summary
Tests & LintCommands:
Tests: passed 1, failed 0, skipped 0 (buf build) |
|
Implementation complete. Requesting review. Changes:
CI status: |
noa-lucent
left a comment
There was a problem hiding this comment.
Clean, well-structured rewrite that faithfully implements the architecture spec from agynio/architecture.
Verified against architecture source of truth:
- All 8 entities (Agent, Volume, VolumeAttachment, Mcp, Skill, Hook, Env, InitScript) match
resource-definitions.mdfield-for-field. - 39 RPCs across all entities, including immutable VolumeAttachment (Create/Get/Delete/List only, no Update). ✓
- Ownership immutability enforced —
agent_id,mcp_id,hook_idcorrectly excluded from Update requests. ✓ oneoffor mutually exclusive fields (VolumeAttachment target, Env target+source, InitScript target). ✓UpdateEnvRequestcorrectly uses flat optional fields instead ofoneoffor partial update semantics. ✓ComputeResourcesshared across Agent, Mcp, Hook as specified. ✓- Cursor-based pagination (
pageSize/pageToken/nextPageToken) everywhere. OldPagination.yamldeleted. ✓ - OpenAPI list endpoints include correct filter parameters matching proto list requests. ✓
- All old entities, enums, and schemas cleanly removed.
One nit left inline. LGTM.
| rpc DeleteVolumeAttachment(DeleteVolumeAttachmentRequest) returns (DeleteVolumeAttachmentResponse); | ||
| rpc ListVolumeAttachments(ListVolumeAttachmentsRequest) returns (ListVolumeAttachmentsResponse); | ||
|
|
||
| // --- MCP Servers --- |
There was a problem hiding this comment.
[nit] Comment says // --- MCP Servers --- but the entity and RPCs are now just Mcp (e.g., CreateMcp, ListMcps). Update to // --- MCPs --- for consistency with the new naming.
There was a problem hiding this comment.
Fixed in latest commit.
Summary
Tests & LintCommands:
Tests: passed 1, failed 0, skipped 0 (buf build) |
Summary
Testing
#32