Skip to content

feat: add service-base chart#2

Merged
rowan-stein merged 6 commits intoagynio:mainfrom
casey-brooks:feat/service-base-0.1.0
Feb 23, 2026
Merged

feat: add service-base chart#2
rowan-stein merged 6 commits intoagynio:mainfrom
casey-brooks:feat/service-base-0.1.0

Conversation

@casey-brooks
Copy link
Contributor

Summary

  • add the service-base Helm library chart templates and helpers
  • add values.yaml and values.schema.json enforcing required invariants
  • add release workflow for GHCR OCI publishing
  • document usage and values in chart README

Testing

  • helm lint charts/service-base --values /tmp/service-base-lint-values.yaml
  • helm template service-base-consumer /tmp/service-base-consumer --values /tmp/service-base-values.yaml

Notes

@casey-brooks
Copy link
Contributor Author

Test & Lint Summary

  • helm lint charts/service-base --values /tmp/service-base-lint-values.yaml (1 chart linted, 0 failed)
  • helm template service-base-consumer /tmp/service-base-consumer --values /tmp/service-base-values.yaml (rendered successfully; 0 tests)

Linting passed with no errors.

Copy link

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary:\n- Library chart does not yet implement several required templates/helpers and values specified in issue #1.\n- Values/schema/template key mismatches (service.ports[], ingress.ingressClassName, metrics labels/annotations, image registry handling, configMounts sourceName).\n- Deployment template missing required sections (init/extra containers, updateStrategy, priorityClassName, terminationGracePeriodSeconds, topologySpreadConstraints) and probe gating.\n\nPlease address the inline comments to align with the spec.

@casey-brooks
Copy link
Contributor Author

Test & Lint Summary

  • helm lint charts/service-base --values /tmp/service-base-lint-values.yaml (1 chart linted, 0 failed)
  • helm template service-base-consumer /tmp/service-base-consumer --values /tmp/service-base-values.yaml (rendered successfully; 0 tests)

Linting passed with no errors.

Copy link

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary:\n- Remaining spec gaps: lifecycle support, security context structure/defaults, and service.labels are still missing.\n- Global imageRegistry precedence should honor global overrides when set.\n\nPlease address the inline comments to align with issue #1.

@casey-brooks
Copy link
Contributor Author

Test & Lint Summary

  • helm lint charts/service-base --values /tmp/service-base-lint-values.yaml (1 chart linted, 0 failed)
  • helm template service-base-consumer /tmp/service-base-consumer --values /tmp/service-base-values.yaml (rendered successfully; 0 tests)

Linting passed with no errors.

Copy link

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary:\n- securityContext schema still missing typed properties for the documented defaults; schema should validate all fields.\n\nPlease address the inline comment.

@casey-brooks
Copy link
Contributor Author

Test & Lint Summary

  • helm lint charts/service-base --values /tmp/service-base-lint-values.yaml (1 chart linted, 0 failed)
  • helm template service-base-consumer /tmp/service-base-consumer --values /tmp/service-base-values.yaml (rendered successfully; 0 tests)

Linting passed with no errors.

Copy link

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary:\n- All requested changes are addressed; values schema now types securityContext defaults.\n- Templates/values align with issue #1 requirements.

@rowan-stein rowan-stein merged commit 1fdd1aa into agynio:main Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants