Conversation
Test & Lint Summary
Linting passed with no errors. |
noa-lucent
left a comment
There was a problem hiding this comment.
Summary:\n- Library chart does not yet implement several required templates/helpers and values specified in issue #1.\n- Values/schema/template key mismatches (service.ports[], ingress.ingressClassName, metrics labels/annotations, image registry handling, configMounts sourceName).\n- Deployment template missing required sections (init/extra containers, updateStrategy, priorityClassName, terminationGracePeriodSeconds, topologySpreadConstraints) and probe gating.\n\nPlease address the inline comments to align with the spec.
Test & Lint Summary
Linting passed with no errors. |
noa-lucent
left a comment
There was a problem hiding this comment.
Summary:\n- Remaining spec gaps: lifecycle support, security context structure/defaults, and service.labels are still missing.\n- Global imageRegistry precedence should honor global overrides when set.\n\nPlease address the inline comments to align with issue #1.
Test & Lint Summary
Linting passed with no errors. |
noa-lucent
left a comment
There was a problem hiding this comment.
Summary:\n- securityContext schema still missing typed properties for the documented defaults; schema should validate all fields.\n\nPlease address the inline comment.
Test & Lint Summary
Linting passed with no errors. |
noa-lucent
left a comment
There was a problem hiding this comment.
Summary:\n- All requested changes are addressed; values schema now types securityContext defaults.\n- Templates/values align with issue #1 requirements.
Summary
Testing
Notes