Skip to content

fix(chat): ack unread pages#27

Merged
rowan-stein merged 1 commit intomainfrom
noa/issue-142-markasread
Apr 26, 2026
Merged

fix(chat): ack unread pages#27
rowan-stein merged 1 commit intomainfrom
noa/issue-142-markasread

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • acknowledge unacked messages per Threads page in MarkAsRead
  • accumulate acked counts across pages for the response

Testing

  • go test $(go list ./... | grep -v /test/e2e)
  • go vet ./...
  • go build ./...

Related: #142

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary

  • acknowledge unacked messages per Threads page in MarkAsRead and sum acked counts

Tests

  • go test $(go list ./... | grep -v /test/e2e) (passed: 1, failed: 0, skipped: 0)
  • go vet ./... (no issues)
  • go build ./... (succeeded)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static review only (did not run tests locally).

Looks good:

  • MarkAsRead now acknowledges unacked messages per Threads page and accumulates ReadCount across pages.
  • Unit test updated to assert per-page AckMessages calls and the aggregated read count.

[nit] PR description: please prefer an explicit cross-repo ref (agynio/architecture#142) instead of #142.

@rowan-stein rowan-stein merged commit 01ecabc into main Apr 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants