Skip to content

fix: add tooltip provider at app root#103

Merged
rowan-stein merged 1 commit into
mainfrom
noa/issue-102
May 23, 2026
Merged

fix: add tooltip provider at app root#103
rowan-stein merged 1 commit into
mainfrom
noa/issue-102

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • Wrap the authenticated app tree with TooltipProvider in src/main.tsx so Radix tooltip usage on organization runner views has a provider ancestor.
  • Add regression coverage for non-cluster-admin organization runners rendering cluster-scoped runners with the disabled View action tooltip path.

Closes #102

Test & Lint Summary

  • npm run typecheck — passed
  • npm run lint — passed with no errors
  • npm run test — 80 passed / 0 failed / 0 skipped
  • npm run build — passed

Manual hover check was not performed because this environment has no browser UI.

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • npm run typecheck — passed
  • npm run lint — passed with no errors
  • npm run test — 80 passed / 0 failed / 0 skipped
  • npm run build — passed

Manual hover check was not performed because this environment has no browser UI.

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete: no blocking issues found. The app root now provides TooltipProvider for authenticated routes, and the regression test covers the non-admin cluster-runner disabled tooltip path without throwing.

Verified locally:

  • npm run generate
  • npm test -- --run src/tests/organization-runners-tab.test.tsx
  • npm run typecheck
  • npm run lint

@rowan-stein
Copy link
Copy Markdown
Contributor

CI update: the e2e job failed during cluster provisioning due to an upstream download error:

  • Error while installing openfga/openfga v0.5.1 ... 502 Bad Gateway

This appears unrelated to the TooltipProvider change in this PR.

Next step: re-run the e2e workflow/job once the upstream provider download is healthy.

@rowan-stein
Copy link
Copy Markdown
Contributor

E2E is still failing in CI, but failures appear unrelated to this PR’s TooltipProvider change.

Most recent failing run: https://github.com/agynio/console-app/actions/runs/26336699631

Notable failures:

  • Go e2e: TestWorkloadStartsOnUnackedMessageUnauthenticated: identity id is required
  • Tracing app Playwright smoke: message-deeplink-empty.spec.ts (empty state element not found)

I opened a tracking issue in agynio/e2e: agynio/e2e#134

Until E2E is green, this PR remains blocked by branch protection.

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Synced noa/issue-102 with latest main and pushed the rebased branch (2aa9bf3). No code changes were made beyond the rebase.

CI re-ran automatically on the updated branch:

Test & Lint Summary

  • npm run generate — passed
  • npm run typecheck — passed
  • npm run lint — passed with no errors
  • npm run test — 80 passed / 0 failed / 0 skipped
  • npm run build — passed

@rowan-stein rowan-stein merged commit 5eb0ef8 into main May 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Runners page crash: Tooltip used without TooltipProvider

3 participants