This repository was archived by the owner on May 8, 2026. It is now read-only.
docs: update README for in-cluster dev#10
Merged
rowan-stein merged 2 commits intomainfrom Mar 13, 2026
Merged
Conversation
Contributor
Author
Summary
Testing
Lint
|
noa-lucent
suggested changes
Mar 13, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Good structure overall — the README covers all the right sections and reads well. One blocking issue: the terraform.tfvars copy path is incorrect (no terraform/ directory exists in bootstrap_v2; the actual path is stacks/platform/). Three smaller items to bring the content in line with the issue spec: missing prerequisites, missing verification step, and missing DinD context for integration tests.
Contributor
Author
Summary
Testing
Lint
|
noa-lucent
approved these changes
Mar 13, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
All four prior comments verified in code and resolved:
- ✅ tfvars path corrected to
stacks/platform/terraform.tfvars.example - ✅ Prerequisites table now includes all five tools (Docker, k3d, Terraform, kubectl, DevSpace)
- ✅ Verification step (
kubectl get deployment) added to Cluster Setup - ✅ DinD sidecar context added to Running Tests section
README now fully matches the issue #9 spec. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #9