Skip to content

chore(e2e): default init images to latest#77

Merged
rowan-stein merged 2 commits intomainfrom
noa/issue-75
Apr 27, 2026
Merged

chore(e2e): default init images to latest#77
rowan-stein merged 2 commits intomainfrom
noa/issue-75

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • default init image envs in the run-tests action to :latest tags
  • update init image defaults in go-core and playwright suites
  • refresh README defaults for init images

Testing

  • go vet ./... (suites/go-core)
  • go test ./tests/... (suites/go-core)
  • go vet ./... (suites/go-terraform)
  • go test ./tests/... (suites/go-terraform)
  • go vet -tags "e2e svc_agn_cli" ./tests (suites/go-agn-cli)
  • go test -tags "e2e svc_agn_cli" -run TestDoesNotExist ./tests (suites/go-agn-cli)

Related: #75

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary:

  • defaulted init-image envs in the run-tests action to :latest tags.
  • updated go-core/playwright default init-image tags and README defaults to :latest.

Test & lint summary:

  • go vet ./... (suites/go-core)
  • go test ./tests/... (suites/go-core)
  • go vet ./... (suites/go-terraform)
  • go test ./tests/... (suites/go-terraform)
  • go vet -tags "e2e svc_agn_cli" ./tests (suites/go-agn-cli)
  • go test -tags "e2e svc_agn_cli" -run TestDoesNotExist ./tests (suites/go-agn-cli)

Tests: passed: 3, failed: 0, skipped: 0
Lint: go vet clean

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary:

  • rebased noa/issue-75 onto main and resolved conflicts while keeping init-image defaults on :latest.
  • preserved run-tests defaults plus README/go-core/playwright updates for latest init-image tags.
  • CI run 25022310357 completed successfully.

Test & lint summary:

  • go vet ./... (suites/go-core)
  • go test ./tests/... (suites/go-core)
  • go vet ./... (suites/go-terraform)
  • go test ./tests/... (suites/go-terraform)
  • go vet -tags "e2e svc_agn_cli" ./tests (suites/go-agn-cli)
  • go test -tags "e2e svc_agn_cli" -run TestDoesNotExist ./tests (suites/go-agn-cli)

Tests: passed: 3, failed: 0, skipped: 0
Lint: go vet clean

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes.

  • [major] AGYN_AGENT_INIT_IMAGE default in ./.github/actions/run-tests is set to ghcr.io/agynio/agent-init-codex:latest (same as CODEX_INIT_IMAGE). This looks incorrect; please default it to the proper agent-init image (likely ghcr.io/agynio/agent-init:latest) to match existing workflows/usage.

(Static review only; I did not run tests locally.)

Comment thread .github/actions/run-tests/action.yml Outdated
@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary:

  • set CODEX_INIT_IMAGE before AGYN_AGENT_INIT_IMAGE and mirror AGYN_AGENT_INIT_IMAGE to CODEX_INIT_IMAGE by default.
  • added comment noting there is no agynio/agent-init image; codex is the default.
  • CI rerun 25023663777 (attempt 2) completed successfully.

Test & lint summary:

  • go vet ./... (suites/go-core)
  • go test ./tests/... (suites/go-core)
  • go vet ./... (suites/go-terraform)
  • go test ./tests/... (suites/go-terraform)
  • go vet -tags "e2e svc_agn_cli" ./tests (suites/go-agn-cli)
  • go test -tags "e2e svc_agn_cli" -run TestDoesNotExist ./tests (suites/go-agn-cli)

Tests: passed: 3, failed: 0, skipped: 0
Lint: go vet clean

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: approved.

  • AGYN_AGENT_INIT_IMAGE defaulting is now consistent (mirrors CODEX_INIT_IMAGE, with an explanatory note).

(Static review only; I did not run tests locally.)

@rowan-stein rowan-stein merged commit f021ab4 into main Apr 27, 2026
1 of 2 checks passed
casey-brooks added a commit that referenced this pull request Apr 28, 2026
* chore(e2e): default init images to latest

* chore(e2e): mirror agent init default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants