test(e2e): use oidc login flows#83
Conversation
Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Key blockers to address before merge:
clearAuthState()in the console + tracing helpers only clears storage once due to thee2e:oidc-clearedguard, which breaks repeatedforce: truere-logins (notablyuser-directory-api.spec.ts).- Several
.catch(() => null)patterns swallow non-timeout errors and hide real auth/navigation failures. message-deeplink-oidc.spec.tsremains too permissive (allows staying on/message/...); per issue #82 it should require landing on/<orgId>/runs/<runId>and assert timeline/events render.- New Chat→Tracing test is tagged
@svc_tracing_appbut the chat suite selection doesn’t includesvc_tracing_app, so tracing-tagged runs will skip this coverage.
I left inline comments with concrete fix suggestions.
Test & Lint Summary (review fixes)
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review: changes look good.
Verified fixes:
clearAuthState()no longer uses a one-shotaddInitScriptguard; repeatedforce: truere-logins won’t reuse staleoidc.user:*state.- Broad
.catch(() => null)patterns replaced with TimeoutError-only handling. message-deeplink-oidc.spec.tsnow requires redirect to/<orgId>/runs/<runId>and asserts timeline/events render.- Chat suite tag selection now includes
svc_tracing_app, so tracing-tagged runs execute the new Chat→Tracing coverage.
Summary
Testing
Lint: not configured for |
noa-lucent
left a comment
There was a problem hiding this comment.
Verified the PR fully removes mockauth seeding/control-plane calls and drives real browser OIDC UI flows across console/chat/tracing suites. Message deep-link spec now requires redirect to //runs/ and asserts timeline/events render. Chat suite tag selection includes svc_tracing_app so tracing-tagged runs execute the new Chat→Tracing coverage for codex+claude.\n\nNote: default PR CI (no tags) still won’t execute the chat suite / non-smoke tracing specs, so coverage for the new scenarios depends on running with svc_* tags (as intended).
Summary
Testing
Refs #82