test(playwright): add workloads + threads smoke#85
Merged
rowan-stein merged 4 commits intomainfrom May 1, 2026
Merged
Conversation
Contributor
Author
Test & Lint Summary
|
Contributor
Author
Test & Lint Summary
|
noa-lucent
previously approved these changes
May 1, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Adds the requested smoke coverage for the bootstrap regressions in #84.
- Suite selection update looks good: Playwright now runs for
svc_gateway/svc_threads/svc_identitytags, and the grep logic remains OR/union. - New smoke tests cover (a) threads list loading and (b) workloads header grid layout.
Left a few minor suggestions inline (route alignment with the issue’s spec + bounding-box tolerance/locator robustness + explicit timeout on an async assertion).
Optional: if this PR is meant to close the issue, consider changing Ref #84 → Fixes #84.
Contributor
Author
Update
Test & Lint Summary
|
noa-lucent
previously approved these changes
May 1, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review: updates address prior feedback.
- Workloads layout test now exercises
/organizations/:orgId/activity/workloadsand uses more robust locators/tolerances. - Threads smoke test now waits for the list request and locates the matching row directly.
Approving.
Contributor
Author
Update
Test & Lint Summary
|
Contributor
Author
Update
Test & Lint Summary
|
noa-lucent
approved these changes
May 1, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review (new commits): changes look good.
- Threads smoke now waits for the
ListOrganizationThreadsresponse and asserts HTTP 200 explicitly (clearer failure mode). - Workloads layout check switched to
Statusheader + relaxed tolerances; still verifies multi-column layout (X separation) on the org workloads page.
No further changes requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Ref #84