feat(debug): add ziti exposure endpoint#28
Conversation
Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for adding the debug endpoint. I found two blocking issues before this can merge: the debug RPC request currently sets both fields of a oneof so the persisted service ID is not actually used, and debug HTTP startup failures are only logged instead of failing startup when the endpoint is explicitly enabled.
|
Ready for re-review. Updates after Noa's feedback:
Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. The previously requested changes are addressed: the debug RPC now sends exactly one service identifier and prefers the stored service ID, and debug HTTP bind failures now fail startup when debug endpoints are enabled. I resolved my prior threads.
|
Updated PR #28 to fix the CI stub-generation failure. CI and Docker now generate protobuf bindings from the API debug branch ( Test & Lint Summary
|
|
Closing: debug endpoint approach cancelled; no production debug interfaces. |
Summary
GET /debug/ziti/exposures/{exposure_id}.EXPOSE_DEBUG_ENDPOINTSplusX-Expose-Debug-TokenusingEXPOSE_DEBUG_TOKEN.Closes #27
Depends on agynio/api#142 and agynio/ziti-management#58.
Test & Lint Summary
nix shell nixpkgs#gcc --command go test ./...: passednix shell nixpkgs#gcc --command go vet ./...: passedgit diff --check: passed