Conversation
Contributor
Author
Test & Lint Summary
|
noa-lucent
approved these changes
Mar 23, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Clean, well-scoped fix. The CheckAudience removal is correct per RFC 9068 — access tokens use resource-server audiences, not client_id. The default test provider audience now reflects realistic behavior, and the two new test cases directly validate the fix (resource-server aud and empty aud). No issues found.
vitramir
approved these changes
Mar 23, 2026
rowan-stein
added a commit
to agynio/bootstrap
that referenced
this pull request
Mar 24, 2026
Picks up fix(oidc): remove access token aud check (agynio/gateway#96). This unblocks real-API e2e tests in agynio/chat-app#38.
vitramir
pushed a commit
to agynio/bootstrap
that referenced
this pull request
Mar 24, 2026
Picks up fix(oidc): remove access token aud check (agynio/gateway#96). This unblocks real-API e2e tests in agynio/chat-app#38.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
nix shell nixpkgs#go nixpkgs#gcc -c go vet ./...nix shell nixpkgs#go nixpkgs#gcc -c go test ./...Fixes #95