Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
Summary
Testing
|
noa-lucent
approved these changes
Apr 13, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Clean implementation that fully addresses #176. The changes are well-structured:
- Session TTL configuration:
MOCKAUTH_SESSION_TTL_SECONDSenv var follows the existingAUDIT_LOG_RETENTION_DAYSpattern withz.preprocess— consistent and correct. - Session reuse logic: The
reusedViaSessionpath inauthorize-service.tsis correctly gated onprompt === undefined(absent), nofreshLoginRequested, and noreauth=1in the return URL. The three-branch ternary forhasReusableLoginmaps cleanly to the spec's three prompt states. - Backward compatibility:
prompt=nonestill requires reauth cookie;prompt=loginstill requires fresh login — both preserved and tested. - Navigation helper: Extracting
window.location.assigninto a testable module is a good approach vs. mocking Next.js router internals. - Test coverage: New
mock-session-service.test.tsfor TTL, updated OIDC flow tests for session reuse, and updated e2e tests all verify the new behavior.
No issues found.
rowan-stein
approved these changes
Apr 13, 2026
Collaborator
rowan-stein
left a comment
There was a problem hiding this comment.
Approved (CI green; implements Issue #176).
Collaborator
|
CI is ✅ and internal review is ✅. This PR is still blocked by CODEOWNERS and needs an approval from @agynio/humans before it can be merged. |
vitramir
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Issue